Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: adapt to voila-sepal-ui template. #909 #910

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Conversation

dfguerrerom
Copy link
Collaborator

@dfguerrerom dfguerrerom commented Mar 29, 2024

This is related to #909.
There are only few changes that I had to do. As I reported in widgetti/ipyvuetify#308, VuetifyTemplates don't have a metadata_id and is not possible to identify them on a straighforward way, that's why I added a class tag to the main scripts we are using "copy to clipboard" and "fullscreen" for maps, in this way they will be displayed in the DOM when using display method.
I didn't set this tag to the other styles and js's we have here because they are obsolete within the new template.

update 04-10-24

Actually, I simplified the full screen event by just adding/removing a css class, that will make the trick work and we'll use less code.

@dfguerrerom
Copy link
Collaborator Author

@12rambau, I came up with a simpler solution for the full screen that doesn't require to use the vuetify template, and works well in both scenarios.

Copy link
Member

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let you decide if you want to accept my suggestion but for the rest it's good to go !

@dfguerrerom dfguerrerom merged commit 4195fa0 into main Apr 12, 2024
1 of 2 checks passed
@dfguerrerom dfguerrerom deleted the sepal-ui-template branch April 12, 2024 12:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants