✨(back) add a retention date / duration policy #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polyhb
force-pushed
the
hbaudesson/retention_date
branch
3 times, most recently
from
70a381c to
4cefce8
Compare
polyhb
force-pushed
the
hbaudesson/retention_date
branch
from
4cefce8 to
ac83c31
Compare
AntoLC
reviewed
Jul 6, 2023
src/frontend/apps/standalone_site/src/features/Playlist/api/useCreatePlaylist/index.ts
Outdated
Show resolved
Hide resolved
AntoLC
reviewed
Jul 6, 2023
src/frontend/apps/standalone_site/src/features/Playlist/components/PlaylistForm.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/standalone_site/src/features/Playlist/components/PlaylistForm.tsx
Show resolved
Hide resolved
src/frontend/apps/standalone_site/src/features/Playlist/components/PlaylistForm.tsx
Outdated
Show resolved
Hide resolved
...standalone_site/src/features/Playlist/features/UpdatePlaylist/api/useUpdatePlaylist/index.ts
Outdated
Show resolved
Hide resolved
...es/lib_classroom/src/components/ClassroomWidgetProvider/widgets/RetentionDate/index.spec.tsx
Outdated
Show resolved
Hide resolved
...ackages/lib_classroom/src/components/ClassroomWidgetProvider/widgets/RetentionDate/index.tsx
Outdated
Show resolved
Hide resolved
...ackages/lib_classroom/src/components/ClassroomWidgetProvider/widgets/RetentionDate/index.tsx
Outdated
Show resolved
Hide resolved
...ndalone_site/src/features/Playlist/features/UpdatePlaylist/components/UpdatePlaylistPage.tsx
Show resolved
Hide resolved
...ne_site/src/features/Playlist/features/UpdatePlaylist/components/UpdatePlaylistPage.spec.tsx
Outdated
Show resolved
Hide resolved
...packages/lib_video/src/components/common/VideoWidgetProvider/widgets/RetentionDate/index.tsx
Outdated
Show resolved
Hide resolved
|
polyhb
force-pushed
the
hbaudesson/retention_date
branch
from
ac83c31 to
a1219e1
Compare
kernicPanel
reviewed
Jul 10, 2023
src/backend/marsha/core/tests/management_commands/test_delete_outdated_videos.py
Show resolved
Hide resolved
AntoLC
approved these changes
Jul 10, 2023
polyhb
force-pushed
the
hbaudesson/retention_date
branch
from
cdd913a to
125fb90
Compare
kernicPanel
approved these changes
Jul 17, 2023
polyhb
force-pushed
the
hbaudesson/retention_date
branch
from
125fb90 to
370d754
Compare
Adding a retention date behavior to our videos and classrooms, through a mixin that can be used on any model. When a object is deleted, this mixin will set an expiration date on the related s3 objects .
Once an object reached its retention date it should be deleted
Adding a retention date/duration field in api responses on playlist, classroom and video objects.
Add the possibility to add / edit the retention duration playlist through the playlist form (create and update)
Add the possibility to add / edit the retention date on video / webinar through a widget
Add the possibility to add / edit the retention date on classrooms through a widget
polyhb
force-pushed
the
hbaudesson/retention_date
branch
from
370d754 to
463edc6
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Clean our unused files and reduce our s3 costs.
Proposal
Adding a retention date behaviour to our videos and classrooms, through a mixin that can be used on any model.
A default retention duration can be set on a playlist, that will be used on the creation of a related object. When a video or a classroom is deleted, we set a default expiration date on the s3 object (that can be defined in the settings).
We also create management commands that will delete outdated classroom / videos once their reached their retention date.