♻️(backends) remove ClickHouse JSON column (#482) #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmtcril
force-pushed
the
bmtcril/remove_json_column
branch
from
6501977 to
de1bb1a
Compare
3 tasks
bmtcril
force-pushed
the
bmtcril/remove_json_column
branch
from
de1bb1a to
ae72750
Compare
wilbrdt
approved these changes
Nov 3, 2023
Initial implementation of the ClickHouse backend used the experimental JSON column type, with the string of the JSON as a backup. The JSON type has never graduated out of experimental status and has some serious issues that make it undesirable to support. This commit removes all references to the column in favor of using the JSON ClickHouse functions, which are generally faster and better supported.
bmtcril
force-pushed
the
bmtcril/remove_json_column
branch
from
ae72750 to
f888ec3
Compare
|
Thanks for the feedback @wilbrdt , it should all be addressed! |
|
Thanks again @bmtcril ! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Initial implementation of the ClickHouse backend used the experimental JSON column type, with the string of the JSON as a backup. The JSON type has never graduated out of experimental status and has some serious issues that make it undesirable to support.
This commit removes all references to the column in favor of using the JSON ClickHouse functions, which are generally faster and better supported.