Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement the ability to notify changes to the web container thread pool under the Config mode. #1133

Merged
merged 12 commits into from
Apr 11, 2023

Conversation

yanrongzhen
Copy link
Member

Fixes #1124

Changes proposed in this pull request:

  • 实现在Config模式下, 对于Web容器的SPI通知能力.
  • 修复bug: 将WebRefreshListener的优先级提升到最高(用于在启动后获取web容器线程池), 防止启动时刷新配置失败的问题.

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.13 ⚠️

Comparison is base (ffaa4fb) 28.12% compared to head (d7d221f) 27.99%.

❗ Current head d7d221f differs from pull request most recent head 17b62f7. Consider uploading reports for the commit 17b62f7 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1133      +/-   ##
=============================================
- Coverage      28.12%   27.99%   -0.13%     
- Complexity       720      721       +1     
=============================================
  Files            258      260       +2     
  Lines           5864     5894      +30     
  Branches         536      539       +3     
=============================================
+ Hits            1649     1650       +1     
- Misses          4060     4089      +29     
  Partials         155      155              
Impacted Files Coverage Δ
.../hippo4j/common/model/ThreadPoolParameterInfo.java 0.00% <ø> (ø)
...ppo4j/message/platform/LarkSendMessageHandler.java 0.00% <ø> (ø)
...platform/base/AbstractRobotSendMessageHandler.java 0.00% <0.00%> (ø)
...message/service/Hippo4jBaseSendMessageService.java 0.00% <0.00%> (ø)
...cn/hippo4j/message/service/SendMessageHandler.java 0.00% <0.00%> (ø)
...sage/service/WebThreadPoolConfigChangeHandler.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@magestacks magestacks merged commit f54d915 into opengoofy:develop Apr 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config模式支持Web容器配置修改通知
2 participants