Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update assertions.js to support SFA #681

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

zheyu1991
Copy link
Contributor

Problem

https://stg-id.singpass.gov.sg/docs/authorization/api, Regular NRIC holders sub claim content include NRIC and UUID (eg. s=S1234567A,u=32af8b7d-ad1d-4c25-8dc7-0a981b533000)
Singpass Foreign Account holders sub claim content include: Singpass User ID (UID), Foreigner ID (FID), Country-of-Issuance (COI) and UUID (e.g. s=Y7613265T,fid=G730Z-H5P96,coi=DE,u=e2af740e-25b4-4b19-b527-494670952cb0)

Closes [insert issue #]

Solution

How did you solve the problem?

lib/assertions.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@PrawiraGenestonlia PrawiraGenestonlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@PrawiraGenestonlia PrawiraGenestonlia merged commit 13aa189 into opengovsg:main Aug 26, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants