Fixing server registration #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now server validates stake status with hub before trying to add workers/register
drortirosh
approved these changes
Jun 1, 2021
| @@ -450,7 +450,6 @@ export class ContractInteractor { | |||
| } | |||
| const rangeSize = toBlock - fromBlock + 1 | |||
| const pagesForRange = Math.max(Math.ceil(rangeSize / this.maxPageSize), 1) | |||
| this.logger.info(`Splitting request for ${rangeSize} blocks into ${pagesForRange} smaller paginated requests!`) | |||
There was a problem hiding this comment.
- No need to log if doing nothing (single part). If you think logging is necessary, you can log if me parts are there.
- Logging should use debug. Info is for one-time (e.g startup code) or highly important (e.g actual sending of a new user tx)
(That is, if you think this log is ever required. Otherwise, it indeed can be removed)
|
@shahafn @drortirosh I see that this PR removes the 'Splitting request for ${rangeSize} blocks' logs entirely, doesn't it? Don't you think these logs might be useful for us later? Maybe it should remain but only print if rangesCount > 1 ? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now server validates stake status with hub before trying to add
workers/register