Add JythonScriptEngineFactory

[5iver]

This pull request adds functionality for a JythonScriptEngineFactory and replaces openhab/openhab-core#1253. This PR only includes Jython 2.7.2 without any helper libraries, which have been submitted as a separate addon (#7210).

Signed-off-by: Scott Rushworth openhab@5iver.com

[5iver]

@cweitkamp, thank you again for the review! It is very nice to see this building properly! I think I have made all of your suggested changes, except for removing the bnd file, which I believe is necessary.

[TravisBuddy]

Travis tests were successful

Hey @openhab-5iver,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[cweitkamp]

Alright. I tested it and it is working. From my side an approval.

We now have to reach an agreement on the namespace in openhab/openhab-core#1319.

[5iver]

Yes, there is the question of the namespace, and also whether the helper libraries need to be included with the ScriptEngineFactories. I've provided as much of an argument as I can muster for the namespace that I used here (I have several more SEFs in queue!) and why it would be best to keep helper libraries separated from the SEFs. It would be very much appreciated if you could weigh in on these in 1319!

Thanks again for the review! If you are interested in an addon for the Jython helper libraries, #7210 also needs reviewing 🙂.

[kaikreuzer]

Yes, there is the question of the namespace

Honestly, there is not really a question on this. Add-ons in this repo have to follow the naming convention org.openhab.<addontype>.<id>.

My suggestion for this PR was hence org.openhab.automation.jythonscripting, but I'd be fine with any other speaking id as well.

[5iver]

There are many more ScriptEngineFactory add-ons to submit, possibly some more helper library add-ons, but I would much rather work on a scripting API than helper libraries for each scripting language, and there are many community helper libraries that could be made into add-ons. Putting them all into this namespace will be ugly and difficult to manage, as I pointed out in openhab/openhab-core#1319 (comment). However, I will accept whatever namespace you force me to use in order to move this PR forward and to finally get it merged into 2.5.x. I suggest then to just take out the separators from the proposal I made three months ago...

org.openhab.automation.scriptenginefactoryjython
org.openhab.automation.helperlibrariesjython
org.openhab.automation.helperlibrariesjythonareatriggersandactions

[kaikreuzer]

I have the feeling that we talk about very different things and thus do not find to a common understanding here - see my comment on openhab/openhab-core#1319 (comment).

[TravisBuddy]

Travis tests have failed

Hey @openhab-5iver,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

[openhab-bot]

Automatic code migration to openHAB 3 succeeded.

The resulting code can be found at https://ci.openhab.org/job/openHAB-Addons-Migration/79/artifact/bundles/.

You can download the migrated code from there and create a new PR against the master branch of the openhab-addons repo to contribute it for being included in openHAB 3.x.

Please see this issue about the details on how to proceed with your existing PR.

[kaikreuzer]

@openhab-5iver Did you port this PR against the main branch? If you require any help, please let me know!