Fix CORS header to allow preflight requests with authorization payload #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orization payload Signed-off-by: Philipp Waller <1090452+philippwaller@users.noreply.github.com>
kaikreuzer
added
rebuild
kaikreuzer
approved these changes
Dec 19, 2020
kaikreuzer
added
the
bug
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
…orization payload (openhab#1963) Signed-off-by: Philipp Waller <1090452+philippwaller@users.noreply.github.com> GitOrigin-RevId: 090b889
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the introduction of the oAuth authorization layer, the CORS filter for preflight requests needs to be adapted. Currently, pre flight requests with an authorization header are rejected by the API.
This pull request corrects this behaviour by adding the value "Authorization" to the "Access-Control-Allow-Headers“.
@kaikreuzer: If it's not too late, this fix might be interesting for the stable release.