Charts: Apply iOS-related fixes only to iOS devices #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the fixes from openhab#2677, openhab#2511, openhab#2706 and openhab#2710 to only apply on iOS devices. Avoids/Fixes regressions with other platforms such as https://community.openhab.org/t/chart-scrollbar/157828. Known issues: - Charts display in popups on iPads are rendered to large. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added
main ui
#2204 Bundle Size — 10.82MiB (~+0.01%).13ee1e0(current) vs 6f01001 main#2203(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2204 |
Baseline #2203 |
|
|---|---|---|
 Initial JS |
1.89MiB |
1.89MiB |
| Initial CSS |
576.5KiB |
576.5KiB |
 Cache Invalidation |
17.79% |
0.01% |
| Chunks |
226 |
226 |
| Assets |
249 |
249 |
| Modules |
2914 |
2914 |
| Duplicate Modules |
149 |
149 |
| Duplicate Code |
1.8% |
1.8% |
| Packages |
96 |
96 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 2 changes 
2 regressions
| Current #2204 |
Baseline #2203 |
|
|---|---|---|
| JS |
9.04MiB (~+0.01%) |
9.04MiB |
| CSS |
862.92KiB (~+0.01%) |
862.88KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.35KiB |
1.35KiB |
| Other |
871B |
871B |
Bundle analysis report Branch florian-h05:chart-page-improve-i... Project dashboard
Generated by RelativeCI Documentation Report issue
florian-h05
added a commit
that referenced
this pull request
Aug 15, 2024
Improves the fixes from #2677, #2511, #2706 and #2710 to only apply to iOS devices. Avoids/Fixes regressions with other platforms such as https://community.openhab.org/t/chart-scrollbar/157828. Known issues: - Charts display in popups on iPads are rendered to large. Signed-off-by: Florian Hotze <florianh_dev@icloud.com> (cherry picked from commit 17c2119)
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Jan 8, 2025
Regression from openhab#2717. Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
added a commit
that referenced
this pull request
Jan 8, 2025
…2991) Fixes known limitation from #2717. Reported on the community: https://community.openhab.org/t/openhab-4-3-release-discussion/160888/155?u=florian-h05 Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
added a commit
that referenced
this pull request
Jan 8, 2025
…2991) Fixes known limitation from #2717. Reported on the community: https://community.openhab.org/t/openhab-4-3-release-discussion/160888/155?u=florian-h05 Signed-off-by: Florian Hotze <dev@florianhotze.com> (cherry picked from commit 7034ad9)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the fixes from #2677, #2511, #2706 and #2710 to only apply to iOS devices.
Avoids/Fixes regressions with other platforms such as https://community.openhab.org/t/chart-scrollbar/157828.
Known issues: