Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

split the isa support file #2116

Merged
merged 5 commits into from
Aug 14, 2023
Merged

split the isa support file #2116

merged 5 commits into from
Aug 14, 2023

Conversation

silabs-krdosvik
Copy link

Added "a lot" of new commits to #2093 (but used rebase to not make a mess) and therefore also a new PR.

  1. splitted the isa_support file into several files.
  2. Fixed dummy assert as it used logic that was removed from the isa_support file (logic copied from uvma_rvfi_instr and made general)

@silabs-krdosvik
add atomic to rvfi_instr_if, expand/divide the support pkg
4a275ce 
Signed-off-by: Kristine Dosvik <krdosvik@silabs.com>
@silabs-krdosvik
divided the isa_support content into the different files, fixed asser…
f72731c 
…tion to use the updated disassembler

Signed-off-by: Kristine Dosvik <krdosvik@silabs.com>
@silabs-krdosvik
remove commented, unpopulated dummy functions
cf0a4ee 
Signed-off-by: Kristine Dosvik <krdosvik@silabs.com>
@silabs-krdosvik
make isa_decoder_pkg
4a37a52 
Signed-off-by: Kristine Dosvik <krdosvik@silabs.com>
silabs-robin
silabs-robin reviewed Aug 14, 2023
View reviewed changes
lib/support/isa_decoder/isa_decoder.sv Outdated Show resolved Hide resolved
lib/support/isa_decoder/isa_decoder_pkg.sv Outdated Show resolved Hide resolved
lib/support/isa_decoder/isa_typedefs.sv Outdated Show resolved Hide resolved
lib/support/isa_decoder/isa_typedefs_csr.sv Outdated Show resolved Hide resolved
lib/support/support_constants.sv Outdated Show resolved Hide resolved
lib/support/support_pkg.sv Outdated Show resolved Hide resolved
@silabs-krdosvik
only use includes in pkg, change compile order in flist, extract isa …
fdd9e5b 
…decoder folder from support folder

Signed-off-by: Kristine Dosvik <krdosvik@silabs.com>
@silabs-krdosvik
Copy link
Author

All of ci check passes now, and fformal compiles.

silabs-robin
silabs-robin approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@silabs-robin silabs-robin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on:
All feedback conversations resolved.

@silabs-robin silabs-robin merged commit e7aa42f into openhwgroup:cv32e40s/dev Aug 14, 2023
@silabs-krdosvik silabs-krdosvik deleted the assert_fixups5 branch August 14, 2023 14:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@silabs-mateilga silabs-mateilga silabs-mateilga left review comments

@silabs-robin silabs-robin silabs-robin approved these changes

Assignees
No one assigned
Labels
cv32e40s cv32e40x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silabs-krdosvik @silabs-mateilga @silabs-robin