Merge Script - "x-dv" Detection #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Pedersen <Robin.Pedersen@silabs.com>
silabs-robin
commented
Aug 14, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
silabs-krdosvik
approved these changes
Aug 14, 2023
MikeOpenHWGroup
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Good idea @silabs-robin. Making this check truly bullet proof may well be impossible, but this is a good attempt.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the merge script checks whether
cv32e40x/is anx-dvclone or not. (Plus some other consistency tweaks.)Rationale: None of my remotes were called
origin, so the script tried to continue even if its prerequisites were not fulfilled.