Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ccover s #2216

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Ccover s #2216

merged 5 commits into from
Sep 28, 2023

Conversation

silabs-krdosvik
Copy link

Added vRefine file for some xsecure and trigger.
Removed signal from assertions as it was not unnecessary (assert property(!resp_ph_cont) passes).

Unglitched formal compiles,
Glitched formal passes.
The assertions are disabled in normal ci check, so have not tested it, but at least hello-world passes.

Signed-off-by: Kristine Dosvik <krdosvik@silabs.com>
…essary signal from assert

Signed-off-by: Kristine Dosvik <krdosvik@silabs.com>
@@ -1,164 +1,197 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<refinement-file-root>
<information comment-version="1" creation-time="Fri 08 Sep 2023 16:33:54 CEST" creator="krdosvik" csCheck="true" modified-by="krdosvik" modify-time="Fri 22 Sep 2023 15:00:52 CEST" save-ref-method="seq" tool-version="Cadence vManager22.05" rules-signature-c="5ec06b80ed3aa56a354242dc7124e080">
Copy link
Author

@silabs-krdosvik silabs-krdosvik Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hem, that I have changed this file was a bit unexpected. I will let it be a drafth PR to I have figured it out.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual_expression_cov_todo.vRefine seems to have changes that was also stored and modified (for the better) in the xsecure_trigger file.

Signed-off-by: Kristine Dosvik <krdosvik@silabs.com>
…r_express_cov file

Signed-off-by: Kristine Dosvik <krdosvik@silabs.com>
@silabs-krdosvik silabs-krdosvik marked this pull request as ready for review September 28, 2023 13:11
Copy link
Contributor

@silabs-robin silabs-robin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on:
Expression coverage analysis is a nice addition.
Test status reported to be ok.
"Removed signal from assertions as it was not unnecessary" broadens the antecedent, so that should be a safe move.

@silabs-robin silabs-robin merged commit 6462d31 into openhwgroup:cv32e40s/dev Sep 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants