Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Directed Test - Pushpop Debug Triggers #2253

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Directed Test - Pushpop Debug Triggers #2253

merged 4 commits into from
Oct 19, 2023

Conversation

silabs-robin
Copy link
Contributor

@silabs-robin silabs-robin commented Oct 18, 2023 •
edited
Loading

This PR adds a directed sanity test for Zc push/pop triggering debug entry.

Test status:

  • The new test - Passes.
  • ci_check - N/A.
  • "full" - Launches and passes the new test.

@silabs-robin
start pushpop triggers test
64720c2 
Signed-off-by: Robin Pedersen <Robin.Pedersen@silabs.com>
@silabs-robin
test push debug triggers
cf3f38c 
Signed-off-by: Robin Pedersen <Robin.Pedersen@silabs.com>
@silabs-robin
test pop debug triggers
cc35f7d 
Signed-off-by: Robin Pedersen <Robin.Pedersen@silabs.com>
@silabs-robin
move pushpop test to standalone
9d39f43 
Signed-off-by: Robin Pedersen <Robin.Pedersen@silabs.com>
@silabs-robin silabs-robin marked this pull request as ready for review October 18, 2023 17:13
silabs-mateilga
silabs-mateilga approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@silabs-mateilga silabs-mateilga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no issues. It's a good idea to test push-pop instructions on an alternate stack.

Approving

silabs-hfegran
silabs-hfegran approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@silabs-hfegran silabs-hfegran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

silabs-krdosvik
silabs-krdosvik approved these changes Oct 19, 2023
View reviewed changes
Copy link

@silabs-krdosvik silabs-krdosvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. At first sight it seems complexed, but when looking deeper into it, it seems like it has the just the complexity it needs (and that it is not that complexed) :-) .

@silabs-robin silabs-robin merged commit 24e9ad2 into openhwgroup:cv32e40s/dev Oct 19, 2023
silabs-robin
silabs-robin commented Oct 19, 2023
View reviewed changes
cv32e40s/tests/programs/custom/pushpop_debug_triggers/pushpop_debug_triggers.c
// Unless required by applicable law or agreed to in writing, any work
// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@silabs-hfegran silabs-hfegran silabs-hfegran approved these changes

@silabs-mateilga silabs-mateilga silabs-mateilga approved these changes

@silabs-krdosvik silabs-krdosvik Awaiting requested review from silabs-krdosvik

Assignees
No one assigned
Labels
cv32e40s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silabs-robin @silabs-mateilga @silabs-hfegran @silabs-krdosvik