Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[WIP] vendor/riscv/riscv-isa-sim: fix yaml-cpp build #2422

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cathales
Copy link
Contributor

@cathales cathales commented May 3, 2024

There are several issues building spike in CVA6 CI:

  1. The yaml-cpp target added by Valentin outputs .h files so it must be run before compiling riscv which directly depends on it, and spike_main which indirectly depends on it.
    The way it was added did not guarantee that so we encountered non-deterministic "missing included .h file" errors at compile-time.
    This should be fixed in this PR thanks to gen_hdrs variables.
  2. (There was an issue with submodule recursive clone but that is solved in CVA6 repository)
  3. There is the same issue at link-time. An _LDFLAGS variable has been added but I feel it does not fix the thing. So this change might not be relevant, and I unfortunately have no time to fix now.
  4. With the current version, some VCS-UVM simulations fail.

@cathales cathales marked this pull request as draft May 3, 2024 15:16
@cathales cathales requested a review from MarioOpenHWGroup May 3, 2024 15:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant