[WIP] vendor/riscv/riscv-isa-sim: fix yaml-cpp build #2422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several issues building spike in CVA6 CI:
yaml-cpp
target added by Valentin outputs.h
files so it must be run before compilingriscv
which directly depends on it, andspike_main
which indirectly depends on it.The way it was added did not guarantee that so we encountered non-deterministic "missing included .h file" errors at compile-time.
This should be fixed in this PR thanks to
gen_hdrs
variables._LDFLAGS
variable has been added but I feel it does not fix the thing. So this change might not be relevant, and I unfortunately have no time to fix now.