Skip to content
This repository has been archived by the owner on Jul 24, 2023. It is now read-only.

Reduce warnings output in test runs: Use assert_nil, File.exist?, avoid useless assignment #119

Merged
merged 4 commits into from
Apr 30, 2019

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Mar 16, 2019

This PR reduces warning output in test runs.

MiniTest deprecations

  • use assert_nil to check for nil

Ruby warnings

  • use the File.exist? method name
  • remove a Hash key duplication
  • avoid assignment to local variables never used

@olleolleolle olleolleolle changed the title Use assert_nil, File.exist? Reduce warnings output in test runs: Use assert_nil, File.exist?, avoid useless assignment Mar 16, 2019
@tobiashm tobiashm merged commit 502b24d into openid:master Apr 30, 2019
@olleolleolle olleolleolle deleted the fix/avoid-test-warnings branch May 1, 2019 04:36
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Nov 18, 2019
Update ruby-ruby-openid package to version 2.9.2.


## 2.9.2

* Perform all checks before verifying endpoints.
  [#126](openid/ruby-openid#126)

## 2.9.1

* Updated CHANGELOG.md

## 2.9.0

* Remove deprecated `autorequire` from gemspec.
  [#123](openid/ruby-openid#123)
* Rescue from `Yadis::XRI::XRIHTTPError` on discovery.
  [#106](openid/ruby-openid#106)
* Avoid SSRF for claimed_id request.
  [#121](openid/ruby-openid#121)
* Updated documentation.
  [#115](openid/ruby-openid#115), [#116](openid/ruby-openid#116), [#117](openid/ruby-openid#117), [#118](openid/ruby-openid#118)
* Reduce warnings output in test runs.
  [#119](openid/ruby-openid#119)
* Drop deprecated option from gemspec.
  [#120](openid/ruby-openid#120)
* Remove circular require.
  [#113](openid/ruby-openid#113)
* Updated Travis CI config with Ruby 2.6
  [#114](openid/ruby-openid#114)
* Simplify Bundler require; remove need for extra `:require`.
  [#112](openid/ruby-openid#112)

## 2.8.0

* Fix `admin/mkassoc` script.
  See openid/ruby-openid#103
* Allow specifying timeout for `OpenID::StandardFetcher` in environment variables.
  See openid/ruby-openid#109
* Fixed some documentation.
  See openid/ruby-openid#111
* Fixed example server.
  See openid/ruby-openid#91
* Fixed tests.
  See openid/ruby-openid#86
* Misc. changes to the CI setup.
  See
  - openid/ruby-openid#110
  - openid/ruby-openid#108
  - openid/ruby-openid#107
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants