8359167: Remove unused test/hotspot/jtreg/vmTestbase/nsk/share/jpda/BindServer.java #25785

plummercj · 2025-06-12T18:01:26Z

The nsk BindServer class is no longer used so it can be removed. This appears to be a remnant left over after the following recent change:

JDK-8333117 Remove support of remote and manual debuggee launchers

There is also some additional cleanup of "manual" and "remote" debuggee launchers done by this PR and fixing some comments that have been wrong for a long time regarding "see also".

Tested by running nsk/jdi, nsk/jdb, and nsk/jdwp tests locally. I'll also run them with tier5 CI once reviews have been done.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8359167: Remove unused test/hotspot/jtreg/vmTestbase/nsk/share/jpda/BindServer.java (Enhancement - P4)

Reviewers

Leonid Mesnik (@lmesnik - Reviewer) Review applies to 21dc4e5d
Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25785/head:pull/25785
$ git checkout pull/25785

Update a local copy of the PR:
$ git checkout pull/25785
$ git pull https://git.openjdk.org/jdk.git pull/25785/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25785

View PR using the GUI difftool:
$ git pr show -t 25785

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25785.diff

Using Webrev

Link to Webrev Comment

…nually started debugees

bridgekeeper · 2025-06-12T18:02:15Z

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-06-12T18:02:46Z

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359167: Remove unused test/hotspot/jtreg/vmTestbase/nsk/share/jpda/BindServer.java

Reviewed-by: sspitsyn, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

382f870: 8357976: GenShen crash in swap_card_tables: Should be clean
8c760e7: 8359418: Test "javax/swing/text/GlyphView/bug4188841.java" failed because the phrase of text pane does not match the instructions
afa52e4: 8210549: Runtime.exec: in closeDescriptors(), use FD_CLOEXEC instead of close()
... and 77 more: https://git.openjdk.org/jdk/compare/429158218b52964ad1e79ba9d2fa5618d6b3398e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-06-12T18:03:28Z

@plummercj The following label will be automatically applied to this pull request:

serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-06-12T18:06:39Z

Webrevs

01: Full - Incremental (ed0999c1)
00: Full (21dc4e5d)

alexmenkov · 2025-06-13T23:33:36Z

test/hotspot/jtreg/vmTestbase/nsk/share/jdb/Launcher.java

 * This class provides launching of <code>jdb</code> and debuggee in local
- * or remote mode according to test command line options.
+ * mode according to test command line options.


As now there is only local mode, I think there is no sense to mention it at all:

* This class provides launching of <code>jdb</code> and debuggee * according to test command line options.

alexmenkov · 2025-06-13T23:34:22Z

test/hotspot/jtreg/vmTestbase/nsk/share/jdb/Launcher.java

@@ -94,7 +94,7 @@ public Launcher (JdbArgumentHandler argumentHandler, Log log) {
    }

    /**
-     * Defines mode (local or remote) and type of connector (default, launching,
+     * Defines mode (local) and type of connector (default, launching,


Suggested change

* Defines mode (local) and type of connector (default, launching,

* Defines type of connector (default, launching,

alexmenkov · 2025-06-13T23:37:32Z

test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java

 * Derived classes should implement these methods corresponding to the mode
- * that the process should be started in (locally, remotely or manually).
+ * that the process should be started in (locally).


I think this can be dropped

Which part?

I guess, Alex suggested to simplify this statement, or maybe to remove it.
This part looks a little bit strange when there is only one (local) mode:
these methods corresponding to the mode.

There are a lot of references to "local" in comments and API names (in most of the files changed, not just DebugeeProcessl.java). I started down the path of cleaning these all up, but there ended up being a lot, and it distracts from the main purpose of this CR, which is removing BindServer.java. I'd rather do the other "local" cleanups in another PR.

It sounds good to me, thanks!

test/hotspot/jtreg/vmTestbase/nsk/share/jpda/IOPipe.java

Co-authored-by: Alex Menkov <alexey.menkov@oracle.com>

sspitsyn

This looks good.

sspitsyn · 2025-06-17T19:36:13Z

test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java

 * Derived classes should implement these methods corresponding to the mode
- * that the process should be started in (locally, remotely or manually).
+ * that the process should be started in (locally).


It sounds good to me, thanks!

sspitsyn · 2025-06-17T22:33:50Z

I was not able to post any comment or approve for a couple of hours. It was some kind of github failure.

plummercj · 2025-06-18T18:42:32Z

Thanks for the reviews Alex, Serguei, and Leonid!

/integrate

openjdk · 2025-06-18T18:43:39Z

Going to push as commit 982064e.
Since your change was applied there have been 94 commits pushed to the master branch:

b52af18: 8359386: Fix incorrect value for max_size of C2CodeStub when APX is used
7bc0d82: 8359227: Code cache/heap size options should be size_t
b7fcd0b: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar
... and 91 more: https://git.openjdk.org/jdk/compare/429158218b52964ad1e79ba9d2fa5618d6b3398e...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-06-18T18:43:47Z

@plummercj Pushed as commit 982064e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Remove unused BindServer and update comments related to remote and ma…

21dc4e5

…nually started debugees

openjdk bot changed the title ~~8359167~~ 8359167: Remove unused test/hotspot/jtreg/vmTestbase/nsk/share/jpda/BindServer.java Jun 12, 2025

openjdk bot added the rfr Pull request is ready for review label Jun 12, 2025

openjdk bot added the serviceability serviceability-dev@openjdk.org label Jun 12, 2025

alexmenkov reviewed Jun 13, 2025

View reviewed changes

lmesnik approved these changes Jun 15, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 15, 2025

Update test/hotspot/jtreg/vmTestbase/nsk/share/jpda/IOPipe.java

ed0999c

Co-authored-by: Alex Menkov <alexey.menkov@oracle.com>

openjdk bot removed the ready Pull request is ready to be integrated label Jun 17, 2025

sspitsyn approved these changes Jun 17, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 17, 2025

openjdk bot added the integrated Pull request has been integrated label Jun 18, 2025

openjdk bot closed this Jun 18, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 18, 2025

	* Defines mode (local) and type of connector (default, launching,
	* Defines type of connector (default, launching,

8359167: Remove unused test/hotspot/jtreg/vmTestbase/nsk/share/jpda/BindServer.java #25785

8359167: Remove unused test/hotspot/jtreg/vmTestbase/nsk/share/jpda/BindServer.java #25785

Uh oh!

Conversation

plummercj commented Jun 12, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jun 12, 2025

Uh oh!

openjdk bot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jun 12, 2025

Uh oh!

mlbridge bot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sspitsyn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sspitsyn commented Jun 17, 2025

Uh oh!

plummercj commented Jun 18, 2025

Uh oh!

openjdk bot commented Jun 18, 2025

Uh oh!

openjdk bot commented Jun 18, 2025

Uh oh!

Uh oh!

plummercj commented Jun 12, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jun 12, 2025 •

edited

Loading

mlbridge bot commented Jun 12, 2025 •

edited

Loading