Skip to content

8360042: GHA: Bump MSVC to 14.44 #25912

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8360042: GHA: Bump MSVC to 14.44 #25912

wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 20, 2025 •
edited by openjdk bot
Loading

See the bug for extended details about this little mess.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25912/head:pull/25912
$ git checkout pull/25912

Update a local copy of the PR:
$ git checkout pull/25912
$ git pull https://git.openjdk.org/jdk.git pull/25912/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25912

View PR using the GUI difftool:
$ git pr show -t 25912

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25912.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 20, 2025 •
edited
Loading

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360042: GHA: Bump MSVC to 14.44

Reviewed-by: erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • fe7ec31: 8359996: Remove unnecessary List.indexOf key from Track.remove
  • 516197f: 8359924: Deprecate and obsolete ParallelRefProcEnabled
  • ad1033d: 8360169: Problem list CodeInvalidationReasonTest.java on linux-riscv64 until JDK-8360168 is fixed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Jun 20, 2025

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jun 20, 2025
@shipilev shipilev mentioned this pull request Jun 20, 2025
Closed
5 tasks
@shipilev
Copy link
Member Author

shipilev commented Jun 20, 2025 •
edited
Loading

Great, I can see that new runner image does not like 14.43. So we are in weird spot at the moment:

  • Old runner image works with 14.43, fails with 14.44
  • New runner image fails with 14.43, works with 14.44
  • Old -> new runner image is currently deploying. About 1/4 of jobs I have seen still get the old runner image at the moment of writing.

Given that new runner image would eventually deploy everywhere, this IMO leaves us with no choice but to do the 14.44 switch now. On the up-side, compared to 14.43, 14.44 is actually claimed to be available by runner docs. With 14.43, we are playing with fire anyway.

@shipilev shipilev marked this pull request as ready for review June 20, 2025 09:02
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 20, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 20, 2025 •
edited
Loading

Webrevs

@vieiro
Copy link

vieiro commented Jun 20, 2025

Looks like it cannot find a C compiler on windows-x64...

[...]
2025-06-20T08:34:28.2275609Z configure: Using default toolchain microsoft (Microsoft Visual Studio)
2025-06-20T08:34:28.4899994Z configure: Found Visual Studio installation at /c/progra~1/micros~2/2022/Enterprise using well-known name
2025-06-20T08:34:28.5299183Z configure: Found Microsoft Visual Studio 2022
2025-06-20T08:34:28.5300257Z configure: Trying to extract Visual Studio environment variables for x86_64
2025-06-20T08:34:28.5301467Z configure: using /c/progra~1/micros~2/2022/Enterprise/vc/auxiliary/build/vcvars64.bat 
2025-06-20T08:34:30.0458930Z configure: Setting extracted environment variables for x86_64
2025-06-20T08:34:30.3769850Z fixpath: warning: Path '/usr/local/bin' does not exist
2025-06-20T08:34:32.5499412Z fixpath: warning: Path '/usr/local/bin' does not exist
2025-06-20T08:34:35.7021325Z checking that Visual Studio variables have been correctly extracted... ok
2025-06-20T08:34:35.7345790Z checking for cl... [not found]
2025-06-20T08:34:35.7347978Z configure: error: Could not find a C compiler. 
2025-06-20T08:34:36.0019320Z configure exiting with result code 1
[...]

FWIW, 14.43 seems to be working fine for JDK11 with the windows-2022 / 14.43 combo:

2025-06-19T09:38:02.7046848Z configure: Using default toolchain microsoft (Microsoft Visual Studio)
2025-06-19T09:38:04.0725116Z configure: Found Visual Studio installation at /c/progra~1/micros~2/2022/Enterprise using well-known name
2025-06-19T09:38:04.1167106Z configure: Found Microsoft Visual Studio 2022
2025-06-19T09:38:04.1168531Z configure: Trying to extract Visual Studio environment variables for x86_64
2025-06-19T09:38:04.1170307Z configure: using /c/progra~1/micros~2/2022/Enterprise/vc/auxiliary/build/vcvarsx86_amd64.bat 
2025-06-19T09:38:05.5593722Z configure: Setting extracted environment variables for x86_64
2025-06-19T09:38:11.3981042Z checking that Visual Studio variables have been correctly extracted... ok
2025-06-19T09:38:11.7820392Z checking for cl... $FIXPATH /c/progra~1/micros~2/2022/enterp~1/vc/tools/msvc/1443~1.348/bin/hostx86/x64/cl.exe
2025-06-19T09:38:11.7830069Z checking resolved symbolic links for CC... no symlink
2025-06-19T09:38:12.0841912Z configure: Using microsoft C compiler version 19.43.34808 [Microsoft (R) C/C++ Optimizing Compiler Version 19.43.34808 for x64]
2025-06-19T09:38:20.8009463Z checking whether the C compiler works... yes
2025-06-19T09:38:20.8010308Z checking for C compiler default output file name... conftest.exe
2025-06-19T09:38:21.0792832Z checking for suffix of executables... .exe

@shipilev
Copy link
Member Author

@vieiro, please read this comment: #25912 (comment) -- we are in transient state.

@shipilev shipilev force-pushed the JDK-8360042-gha-msvc-14.44 branch from cdb8e22 to 222006d Compare June 23, 2025 08:03
@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@shipilev
Copy link
Member Author

shipilev commented Jun 23, 2025 •
edited
Loading

Looks like 20250617.1.0 runner image have been deployed. I also see mainline PR GHA runs fail left and right, as observed earlier: #25912 (comment). So we can and should go in with this PR now. Please review. (Looks at general vicinity of @magicus, who is probably trying not to look into this mess again.)

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 23, 2025
magicus
magicus approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you say, it probably can't get worse.

@shipilev
Copy link
Member Author

shipilev commented Jun 23, 2025 •
edited
Loading

2x GHA run is clean.

As you say, it probably can't get worse.

We shall see about that! :)

To err is human, to propagate an error to thousands of computers is DevOps.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2025

Going to push as commit 72679c9.
Since your change was applied there have been 5 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2025
@openjdk openjdk bot closed this Jun 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2025
@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@shipilev Pushed as commit 72679c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@magicus magicus magicus approved these changes

@erikj79 erikj79 erikj79 approved these changes

Assignees
No one assigned
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shipilev @vieiro @magicus @erikj79