Skip to content

8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings #3632

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 13, 2025

Hi all,

This pull request contains a backport of commit b1b66965 from the openjdk/jdk repository.

The commit being backported was authored by Aleksey Shipilev on 29 Sep 2021 and was reviewed by Daniel Fuchs.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8274453 needs maintainer approval

Issue

  • JDK-8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3632/head:pull/3632
$ git checkout pull/3632

Update a local copy of the PR:
$ git checkout pull/3632
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3632/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3632

View PR using the GUI difftool:
$ git pr show -t 3632

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3632.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b1b66965f1ec6eae547cc4f70f8271bd39ded6da 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings Jun 13, 2025
@openjdk
Copy link

openjdk bot commented Jun 13, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 13, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 13, 2025
@sendaoYan
Copy link
Member Author

/approval Clean backport to fix the test bug which avoid additional warning output of lsof make test fails. Test-fix only, no risk,

@mlbridge
Copy link

mlbridge bot commented Jun 13, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 13, 2025

@sendaoYan usage: /approval [<id>] (request|cancel) [<text>]

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant