Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Clean up frozen author attribute logic #58

Open
joemull opened this issue Apr 1, 2022 · 1 comment
Open

Clean up frozen author attribute logic #58

joemull opened this issue Apr 1, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@joemull
Copy link
Member

joemull commented Apr 1, 2022

Now that the Account and FrozenAuthor models correspond better (as via openlibhums/janeway#2820) we should clean up a bit of the logic that adds author data to exports.
@joemull joemull added the enhancement New feature or request label Apr 1, 2022
@joemull joemull added this to v1.4.2 Apr 1, 2022
@joemull joemull moved this to Todo in v1.4.2 May 30, 2022
@ajrbyers ajrbyers removed this from v1.4.2 Jun 9, 2022
@ajrbyers
Copy link
Member

ajrbyers commented Aug 3, 2022

Stuff to do:

  • Add to snapshot author method
  • Check for frozen_author.account.salutation and replace with frozen_author.salutation property
  • Add salutation to FA field

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajrbyers @joemull