Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add suffix to account model and snapshot #2820

Closed
joemull opened this issue Apr 1, 2022 · 4 comments · Fixed by #3084
Closed

Add suffix to account model and snapshot #2820

joemull opened this issue Apr 1, 2022 · 4 comments · Fixed by #3084
Assignees
Labels
new feature A new thing that doesn't exist yet

Comments

@joemull
Copy link
Member

joemull commented Apr 1, 2022

Is your feature request related to a problem? Please describe.
The salutation attribute of Account needs to be added to the FrozenAuthor model as frozen_salutation along with a salutation() function property, similar to other frozen author attributes.

@joemull joemull added the new feature A new thing that doesn't exist yet label Apr 1, 2022
@joemull joemull self-assigned this Apr 1, 2022
@joemull joemull added this to v1.4.2 Apr 1, 2022
@joemull joemull moved this to Todo in v1.4.2 Apr 1, 2022
@joemull joemull removed their assignment Apr 1, 2022
@ajrbyers ajrbyers added this to v1.4.3 Jun 9, 2022
@ajrbyers ajrbyers moved this to Todo in v1.4.3 Jun 9, 2022
@ajrbyers ajrbyers removed this from v1.4.2 Jun 9, 2022
@mauromsl mauromsl self-assigned this Jun 20, 2022
@ajrbyers
Copy link
Member

Additionally can we add suffix? From #2938

Is your feature request related to a problem? Please describe.
As an author who publishes using my title and name, including suffix, I want to be able to represent my name in full in Janeway. If I add my title to the Given Name field and suffix to the Family Name field, then there may be errors registering DOIs which my name in the metadata.

Describe the solution you'd like
Add a prefix/title field and a suffix field to the account table
(?) Add support for prefix/suffix in output DOI metadata (?)

@alainna
Copy link
Contributor

alainna commented Jul 26, 2022

@ajrbyers Just confirming: This would make it possible to add Titles/prefixes/salutations and suffixes to the account table for authors, right?
(Thinking of the notices we get from Crossref every time a "Jr" or "III" is in the Familyname field. 😅 )
Thanks!

@ajrbyers
Copy link
Member

@ajrbyers Just confirming: This would make it possible to add Titles/prefixes/salutations and suffixes to the account table for authors, right? (Thinking of the notices we get from Crossref every time a "Jr" or "III" is in the Familyname field. 😅 ) Thanks!

Yup!

@mauromsl mauromsl removed their assignment Aug 2, 2022
@ajrbyers ajrbyers self-assigned this Aug 2, 2022
@ajrbyers
Copy link
Member

ajrbyers commented Aug 3, 2022

Update:

name_prefix already exists and we've decided not to snapshot this, after a discussion it was agreed that:

  • We should add suffix to the Account model
  • It should be snapshotted
  • It should be passed to crossref

@ajrbyers ajrbyers changed the title Add salutation to frozen author model Add suffix to account model and snapshot Aug 9, 2022
@ajrbyers ajrbyers moved this from Todo to PR Submitted in v1.4.3 Aug 15, 2022
mauromsl added a commit that referenced this issue Sep 13, 2022
#2820 Accounts now have a suffix field that will be snapshotted into Frozen Authors
Repository owner moved this from PR Submitted to Done in v1.4.3 Sep 13, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
new feature A new thing that doesn't exist yet
Projects
No open projects
Status: Done
4 participants