Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Public profile page links to broken article URLs from other journals #2841

Closed
mauromsl opened this issue Apr 7, 2022 · 1 comment · Fixed by #3124
Closed

Public profile page links to broken article URLs from other journals #2841

mauromsl opened this issue Apr 7, 2022 · 1 comment · Fixed by #3124
Assignees
Labels
bug Something's not working

Comments

@mauromsl
Copy link
Member

mauromsl commented Apr 7, 2022

Describe the bug
On the user public profile page, publications from other journals are rendered using the article_listing component.
This component renders article urls using the journal_url template tag which uses the current journal (request.journal) to construct the URL. In situations where the journal is configured with a custom domain, this leads to a broken URL.

The same problem occurs with the thumbnail URL which won't load properly.

We should either use absolute URLs for the articles (submission,models.Article.url) in article_listing.html or drop articles from other journals being listed from the user's public profile.

Janeway version
v1.4.1-RC-6

To Reproduce
Steps to reproduce the behavior:

  1. Create a user with publications on two or more journals
  2. visit the user profile page from one of the journals
  3. See error on article URLs from other journals

Expected behavior
Either the URLs resolve correctly to the other journals or this articles to be omitted

Screenshots
image

Front-end Issues

If the issue is front-end specific please add the following details:

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
@mauromsl mauromsl added the bug Something's not working label Apr 7, 2022
@ajrbyers ajrbyers self-assigned this Jul 20, 2022
@ajrbyers ajrbyers added this to v1.4.3 Jul 20, 2022
@ajrbyers ajrbyers moved this to Todo in v1.4.3 Jul 20, 2022
ajrbyers added a commit that referenced this issue Jul 22, 2022
@ajrbyers ajrbyers moved this from Todo to PR Submitted in v1.4.3 Jul 22, 2022
@joemull
Copy link
Member

joemull commented Sep 7, 2022

@ajrbyers I don't believe this one has a PR yet. It's ready for one, right?

Repository owner moved this from PR Submitted to Done in v1.4.3 Sep 8, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something's not working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants