Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

"Modified" date column in Typesetting Plugin no longer populating #2904

Closed
pgoussy opened this issue Jun 1, 2022 · 1 comment · Fixed by #3032
Closed

"Modified" date column in Typesetting Plugin no longer populating #2904

pgoussy opened this issue Jun 1, 2022 · 1 comment · Fixed by #3032
Assignees
Labels
bug Something's not working

Comments

@pgoussy
Copy link

pgoussy commented Jun 1, 2022

Describe the bug
In the Typesetting Plugin, the Modified column no longer displays the date the typeset file was last modified, as it used to. This occurs in both the top-level Typesetting Plugin ("Current Typeset Files" box) and in each individual galley's Edit Typeset File page. The latter feels more problematic in practical use, since there's no longer an indication of whether or not I've already edited a typeset file that I clicked in to replace.

Janeway version
Currently 1.4.1; I don't recall when it started happening, but it's been a couple of months at least (I just kept forgetting to report it).

To Reproduce
Steps to reproduce the behavior:

  1. Go to the archive page of any published article. (e.g. https://journals.publishing.umich.edu/ergo/manage/archive/article/1113/)
  2. Click the "Typesetting Plugin" button in the top menu bar. (e.g. https://journals.publishing.umich.edu/ergo/plugins/typesetting/article/1113/)
  3. Scroll down to the Current Typeset Files.

Expected behavior
"Modified" column should display the date (and time?) that the typeset file was last modified.

Screenshots
2022-06-01_09-35-24
2022-06-01_09-34-57

@pgoussy pgoussy added the bug Something's not working label Jun 1, 2022
@pgoussy pgoussy changed the title "Modified" date column in Typesetting Plugin no longer displaying "Modified" date column in Typesetting Plugin no longer populating Jun 1, 2022
@mauromsl
Copy link
Member

mauromsl commented Jun 1, 2022

This a side-effect of the changes made in #2804 (removed the old date_modified column from core_file)

We should add a property to to the model with a deprecation notice, preserving the old interface.

I've also raised an issue to update typesetting plugin: openlibhums/typesetting#158

@mauromsl mauromsl added this to v1.4.2 Jun 1, 2022
@mauromsl mauromsl self-assigned this Jun 1, 2022
@ajrbyers ajrbyers moved this to Todo in v1.4.2 Jun 9, 2022
@ajrbyers ajrbyers removed this from v1.4.2 Jun 9, 2022
@ajrbyers ajrbyers added this to v1.4.3 Jul 20, 2022
@ajrbyers ajrbyers self-assigned this Jul 20, 2022
@ajrbyers ajrbyers moved this to Todo in v1.4.3 Jul 20, 2022
ajrbyers added a commit that referenced this issue Jul 22, 2022
@ajrbyers ajrbyers moved this from Todo to PR Submitted in v1.4.3 Jul 22, 2022
joemull added a commit that referenced this issue Sep 9, 2022
#2904 fixes an issue that caused modified dates for File objects not to show up
Repository owner moved this from PR Submitted to Done in v1.4.3 Sep 9, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something's not working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants