Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Article galleys can be downloaded before the article is published if you know the URL #3977

Closed
mauromsl opened this issue Feb 20, 2024 · 0 comments · Fixed by #3978
Closed

Article galleys can be downloaded before the article is published if you know the URL #3977

mauromsl opened this issue Feb 20, 2024 · 0 comments · Fixed by #3978
Assignees
@mauromsl
Labels
bug Something's not working size XS Extra small

Comments

@mauromsl
Copy link
Member

Describe the bug
The /article/id/{id}/download/{pdf/xml} URLs are currently allowing unauthenticated users to download a galley even before the article is published

Janeway version
v1.5.1

Expected behavior
Articles that are not yet published should return a 404 on those URLs
@mauromsl mauromsl added bug Something's not working size XS Extra small labels Feb 20, 2024
@github-project-automation github-project-automation bot moved this to 📋 Todo in v1.5.1 Archer Feb 20, 2024
mauromsl added a commit that referenced this issue Feb 20, 2024
@mauromsl
#3977: Download XML/PDF urls only available if article is published
024bc7e
@mauromsl mauromsl mentioned this issue Feb 20, 2024
Merged
@mauromsl mauromsl self-assigned this Feb 20, 2024
@mauromsl mauromsl moved this from 📋 Todo to 📝 PR Submitted in v1.5.1 Archer Feb 20, 2024
ajrbyers pushed a commit that referenced this issue Feb 20, 2024
@mauromsl @ajrbyers
#3977: Download XML/PDF urls only available if article is published
bb0807b
@github-project-automation github-project-automation bot moved this from 📝 PR Submitted to ✅ Done in v1.5.1 Archer Feb 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mauromsl mauromsl

Labels
bug Something's not working size XS Extra small
Projects
No open projects
v1.5.1 Archer
Status: ✅ Done
Milestone
No milestone
2 participants
@ajrbyers @mauromsl