Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow horizontal resizing but not full screen toggling of TinyMCE editor #4034

Closed
joemull opened this issue Mar 18, 2024 · 0 comments · Fixed by #4045
Closed

Allow horizontal resizing but not full screen toggling of TinyMCE editor #4034

joemull opened this issue Mar 18, 2024 · 0 comments · Fixed by #4045
Assignees
Labels
a11y Issues that relate to acessibility bug Something's not working

Comments

@joemull
Copy link
Member

joemull commented Mar 18, 2024

Problem

We have currently allowed the fullscreen feature on the TinyMCE editor. It has some accessibility issues when combined with our themes. The Escape key does not allow you to exit the full-screen view on Firefox on the OLH theme or the Hourglass theme. And on the Hourglass theme, the sticky nav bar covers up the visual interface for exiting full screen. As such it is a bit of a trap.

OLH theme - no escape key

image

Hourglass theme - no Escape key or button

image

Proposed solution

Rather than enabling the fullscreen toggle, use the resize options to allow both horizontal and vertical resizing.

We currently have an invalid setting for "resize":

https://github.com/BirkbeckCTP/janeway/blob/d52b7719bf2bad26a9779246cf3305f0aa753ea2/src/core/janeway_global_settings.py#L680

image

This should be True, False, or 'both'. We can use both to allow resizing in both directions, like this:

image

Alternatives

I tried debugging the Escape key event and the covered-up nav but could not do so in the time we have.

Additional context

TinyMCE docs: Controlling user editor resizing

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
a11y Issues that relate to acessibility bug Something's not working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants