Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds support for Issue and Journal DOIs to Crossref Integration #3128

Merged
merged 14 commits into from
Sep 14, 2022

Conversation

mauromsl
Copy link
Member

@mauromsl mauromsl commented Sep 9, 2022

For journal issues, it includes settings and an event that allows an issue DOI to be automatically assigned, similar to how article DOIs are autogenerated from a pattern. The event is raised when an article is first added to an issue.
Closes #2817
closes #2826

@joemull joemull self-requested a review September 12, 2022 11:05
@joemull joemull self-assigned this Sep 12, 2022
Copy link
Member

@joemull joemull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great--I think it will be very useful.

There are a few potential bugs that I managed to catch. Comments inline.

@mauromsl mauromsl requested a review from joemull September 13, 2022 09:20
save_setting('Identifiers', 'register_issue_dois', self.journal_one, '')
from events import registration # Forces events to load into memory
journal_logic.handle_assign_issue(self.request, self.article_one, issue)
issue.refresh_from_db()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that is a useful method.

@joemull joemull merged commit bcf7617 into master Sep 14, 2022
@joemull joemull deleted the 2817-register-issue-journal-dois branch September 14, 2022 13:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title Level DOI Feature to register issue DOI's
3 participants