Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test fixes for version 1.4.3-release-candidate-0 #3158

Merged
merged 6 commits into from
Sep 27, 2022

Conversation

joemull
Copy link
Member

@joemull joemull commented Sep 26, 2022

No description provided.

@joemull joemull requested a review from ajrbyers September 26, 2022 13:56
@joemull
Copy link
Member Author

joemull commented Sep 26, 2022

@ajrbyers This should be good to go. As a warning, bc31ffc represents a kind of fanatical but ultimately necessary standardization of how we create and query role names and slugs, at least in testing.

@ajrbyers
Copy link
Member

@joemull this looks good, the only thing to check is whether the typesetting plugin uses this role. I don't think it does though.

@ajrbyers ajrbyers merged commit 78d1e73 into master Sep 27, 2022
@ajrbyers ajrbyers deleted the test_fixes_1_4_3_rc_0 branch September 27, 2022 08:31
@joemull
Copy link
Member Author

joemull commented Sep 27, 2022

@joemull this looks good, the only thing to check is whether the typesetting plugin uses this role. I don't think it does though.

Good catch--I just checked and there aren't any uses of role in the typesetting plugin that would run afoul of these changes.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants