#3906 un-nest labels and inputs in themes

[StephDriver]

all file search for labels which nested their input and only two were found, both in theme templates marked as depreciated in 1.5.1.

Labels elsewhere looked un-nested, and hence avoiding this issue.

Closes #3906

[ajrbyers]

This is okay, does the display remain the same after the change?

[joemull]

Just thought I'd mention this template is no longer used, to my knowledge. I added this deprecation note recently when I switched this interface to using a class-based view:

https://github.com/BirkbeckCTP/janeway/blob/9fcbbe87b917bf3c4ce1d64b85d579f7c0634069/src/themes/OLH/templates/elements/journal/article_filter_form.html#L1

Maybe I should have just deleted the template? I wasn't confident doing so without more front-end tests in place.

[ajrbyers]

Just thought I'd mention this template is no longer used, to my knowledge. I added this deprecation note recently when I switched this interface to using a class-based view:

https://github.com/BirkbeckCTP/janeway/blob/9fcbbe87b917bf3c4ce1d64b85d579f7c0634069/src/themes/OLH/templates/elements/journal/article_filter_form.html#L1

Maybe I should have just deleted the template? I wasn't confident doing so without more front-end tests in place.

I think its safe to remove it in 1.6. Any break in rendering of the article list view will be picked up by https://github.com/BirkbeckCTP/janeway/blob/9fcbbe87b917bf3c4ce1d64b85d579f7c0634069/src/journal/tests/test_journal_frontend.py#L98-L112.

[joemull]

@ajrbyers Brilliant! I've added an issue for it.