Fixes an issue where multiple jump links appear in an article's workflow nav when it has been moved through the workflow in a non linear fashion #4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rather than using stages, will also reduce the number of queries.
joemull
approved these changes
Mar 13, 2024
mauromsl
reviewed
Mar 19, 2024
src/submission/models.py
Outdated
Comment on lines
1683
to
1691
| workflow_element_ids = core_models.WorkflowLog.objects.filter( | ||
| article=self, | ||
| ).values_list( | ||
| 'element' | ||
| ).distinct() | ||
|
|
||
| return core_models.WorkflowElement.objects.filter( | ||
| pk__in=[element_id[0] for element_id in workflow_element_ids] | ||
| ) |
There was a problem hiding this comment.
Super minor nitpick:
Can be a bit more compact with:
WorkflowElement.objects.filter(
pk__in=article.workflowlog_set.values_list("element").distinct()
)
|
Super minor optional comment inline but good to merge |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
workflow_stagesis used elsewhere I've opted to add a new method that explicitly returns distinctWorkflowElements. This will also reduce the number of queries run as the template will no longer be fetching related items.Closes #3593