Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(fix) Allow immutable arguments to config validators #1019

Merged
merged 1 commit into from
May 29, 2024

Conversation

brandones
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Trivial change; this just allows you to pass a readonly type to validators.

Screenshots

Related Issue

Other

@brandones brandones requested review from denniskigen and ibacher May 29, 2024 20:51
Copy link
Contributor

Size Change: 0 B

Total Size: 3.46 MB

ℹ️ View Unchanged
Filename Size
packages/apps/esm-devtools-app/dist/630.js 2.69 kB
packages/apps/esm-devtools-app/dist/667.js 6.96 kB
packages/apps/esm-devtools-app/dist/735.js 2.63 kB
packages/apps/esm-devtools-app/dist/788.js 42.9 kB
packages/apps/esm-devtools-app/dist/875.js 9.84 kB
packages/apps/esm-devtools-app/dist/884.js 15.2 kB
packages/apps/esm-devtools-app/dist/885.js 27.1 kB
packages/apps/esm-devtools-app/dist/889.js 159 kB
packages/apps/esm-devtools-app/dist/988.js 328 B
packages/apps/esm-devtools-app/dist/main.js 3.14 kB
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js 3.19 kB
packages/apps/esm-implementer-tools-app/dist/271.js 716 B
packages/apps/esm-implementer-tools-app/dist/319.js 637 B
packages/apps/esm-implementer-tools-app/dist/426.js 24.8 kB
packages/apps/esm-implementer-tools-app/dist/460.js 735 B
packages/apps/esm-implementer-tools-app/dist/482.js 15.2 kB
packages/apps/esm-implementer-tools-app/dist/523.js 5.73 kB
packages/apps/esm-implementer-tools-app/dist/528.js 133 kB
packages/apps/esm-implementer-tools-app/dist/56.js 3.07 kB
packages/apps/esm-implementer-tools-app/dist/560.js 13.8 kB
packages/apps/esm-implementer-tools-app/dist/574.js 560 B
packages/apps/esm-implementer-tools-app/dist/587.js 2.92 kB
packages/apps/esm-implementer-tools-app/dist/620.js 126 kB
packages/apps/esm-implementer-tools-app/dist/625.js 562 B
packages/apps/esm-implementer-tools-app/dist/644.js 717 B
packages/apps/esm-implementer-tools-app/dist/657.js 7.01 kB
packages/apps/esm-implementer-tools-app/dist/71.js 6.97 kB
packages/apps/esm-implementer-tools-app/dist/735.js 2.63 kB
packages/apps/esm-implementer-tools-app/dist/757.js 560 B
packages/apps/esm-implementer-tools-app/dist/788.js 42.9 kB
packages/apps/esm-implementer-tools-app/dist/791.js 284 B
packages/apps/esm-implementer-tools-app/dist/807.js 559 B
packages/apps/esm-implementer-tools-app/dist/833.js 681 B
packages/apps/esm-implementer-tools-app/dist/889.js 159 kB
packages/apps/esm-implementer-tools-app/dist/891.js 61.3 kB
packages/apps/esm-implementer-tools-app/dist/main.js 78.1 kB
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 3.31 kB
packages/apps/esm-login-app/dist/111.js 1.22 kB
packages/apps/esm-login-app/dist/126.js 2.5 kB
packages/apps/esm-login-app/dist/173.js 1.22 kB
packages/apps/esm-login-app/dist/224.js 256 B
packages/apps/esm-login-app/dist/236.js 272 B
packages/apps/esm-login-app/dist/240.js 364 B
packages/apps/esm-login-app/dist/271.js 718 B
packages/apps/esm-login-app/dist/272.js 264 B
packages/apps/esm-login-app/dist/319.js 679 B
packages/apps/esm-login-app/dist/336.js 234 B
packages/apps/esm-login-app/dist/363.js 30.5 kB
packages/apps/esm-login-app/dist/460.js 737 B
packages/apps/esm-login-app/dist/539.js 298 B
packages/apps/esm-login-app/dist/56.js 3.06 kB
packages/apps/esm-login-app/dist/574.js 577 B
packages/apps/esm-login-app/dist/625.js 579 B
packages/apps/esm-login-app/dist/627.js 257 B
packages/apps/esm-login-app/dist/63.js 16.5 kB
packages/apps/esm-login-app/dist/644.js 718 B
packages/apps/esm-login-app/dist/667.js 6.96 kB
packages/apps/esm-login-app/dist/673.js 284 B
packages/apps/esm-login-app/dist/735.js 2.63 kB
packages/apps/esm-login-app/dist/757.js 660 B
packages/apps/esm-login-app/dist/788.js 42.9 kB
packages/apps/esm-login-app/dist/807.js 897 B
packages/apps/esm-login-app/dist/833.js 684 B
packages/apps/esm-login-app/dist/884.js 15.2 kB
packages/apps/esm-login-app/dist/889.js 159 kB
packages/apps/esm-login-app/dist/905.js 22 kB
packages/apps/esm-login-app/dist/main.js 56.5 kB
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js 3.37 kB
packages/apps/esm-offline-tools-app/dist/271.js 1.18 kB
packages/apps/esm-offline-tools-app/dist/319.js 1.13 kB
packages/apps/esm-offline-tools-app/dist/460.js 1.29 kB
packages/apps/esm-offline-tools-app/dist/56.js 3.07 kB
packages/apps/esm-offline-tools-app/dist/574.js 1.04 kB
packages/apps/esm-offline-tools-app/dist/625.js 1.04 kB
packages/apps/esm-offline-tools-app/dist/63.js 16.5 kB
packages/apps/esm-offline-tools-app/dist/644.js 1.18 kB
packages/apps/esm-offline-tools-app/dist/667.js 6.96 kB
packages/apps/esm-offline-tools-app/dist/735.js 2.63 kB
packages/apps/esm-offline-tools-app/dist/757.js 1.2 kB
packages/apps/esm-offline-tools-app/dist/788.js 42.9 kB
packages/apps/esm-offline-tools-app/dist/807.js 1.11 kB
packages/apps/esm-offline-tools-app/dist/833.js 1.21 kB
packages/apps/esm-offline-tools-app/dist/884.js 15.2 kB
packages/apps/esm-offline-tools-app/dist/889.js 159 kB
packages/apps/esm-offline-tools-app/dist/922.js 90.9 kB
packages/apps/esm-offline-tools-app/dist/975.js 56.6 kB
packages/apps/esm-offline-tools-app/dist/main.js 147 kB
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js 3.29 kB
packages/apps/esm-primary-navigation-app/dist/271.js 267 B
packages/apps/esm-primary-navigation-app/dist/319.js 237 B
packages/apps/esm-primary-navigation-app/dist/380.js 22.8 kB
packages/apps/esm-primary-navigation-app/dist/460.js 264 B
packages/apps/esm-primary-navigation-app/dist/574.js 230 B
packages/apps/esm-primary-navigation-app/dist/625.js 232 B
packages/apps/esm-primary-navigation-app/dist/63.js 16.5 kB
packages/apps/esm-primary-navigation-app/dist/644.js 267 B
packages/apps/esm-primary-navigation-app/dist/667.js 6.97 kB
packages/apps/esm-primary-navigation-app/dist/735.js 2.64 kB
packages/apps/esm-primary-navigation-app/dist/757.js 238 B
packages/apps/esm-primary-navigation-app/dist/762.js 7.61 kB
packages/apps/esm-primary-navigation-app/dist/788.js 42.9 kB
packages/apps/esm-primary-navigation-app/dist/807.js 290 B
packages/apps/esm-primary-navigation-app/dist/833.js 257 B
packages/apps/esm-primary-navigation-app/dist/884.js 15.2 kB
packages/apps/esm-primary-navigation-app/dist/889.js 159 kB
packages/apps/esm-primary-navigation-app/dist/958.js 22.7 kB
packages/apps/esm-primary-navigation-app/dist/main.js 47 kB
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js 3.23 kB
packages/framework/esm-api/dist/openmrs-esm-api.js 16.3 kB
packages/framework/esm-config/dist/openmrs-esm-module-config.js 8.02 kB
packages/framework/esm-context/dist/openmrs-esm-context.js 1.1 kB
packages/framework/esm-dynamic-loading/dist/openmrs-esm-dynamic-loading.js 2.75 kB
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js 889 B
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js 8.14 kB
packages/framework/esm-feature-flags/dist/openmrs-esm-feature-flags.js 1.67 kB
packages/framework/esm-framework/dist/126.openmrs-esm-framework.js 2.47 kB
packages/framework/esm-framework/dist/278.openmrs-esm-framework.js 14.5 kB
packages/framework/esm-framework/dist/530.openmrs-esm-framework.js 2.92 kB
packages/framework/esm-framework/dist/619.openmrs-esm-framework.js 6.49 kB
packages/framework/esm-framework/dist/645.openmrs-esm-framework.js 9.31 kB
packages/framework/esm-framework/dist/680.openmrs-esm-framework.js 6.13 kB
packages/framework/esm-framework/dist/735.openmrs-esm-framework.js 2.66 kB
packages/framework/esm-framework/dist/788.openmrs-esm-framework.js 42.9 kB
packages/framework/esm-framework/dist/openmrs-esm-framework.js 486 kB
packages/framework/esm-globals/dist/openmrs-esm-globals.js 796 B
packages/framework/esm-navigation/dist/openmrs-esm-navigation.js 9.35 kB
packages/framework/esm-offline/dist/openmrs-esm-offline.js 34.4 kB
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js 15.6 kB
packages/framework/esm-routes/dist/openmrs-esm-utils.js 1.46 kB
packages/framework/esm-state/dist/openmrs-esm-state.js 921 B
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js 48.8 kB
packages/framework/esm-translations/dist/openmrs-esm-core-translations.js 1.59 kB
packages/framework/esm-utils/dist/openmrs-esm-utils.js 18.2 kB
packages/shell/esm-app-shell/dist/11c63b65f96a8718.js 499 B
packages/shell/esm-app-shell/dist/1e0131662341578e.js 645 B
packages/shell/esm-app-shell/dist/2916d0aa7a9d5dc8.js 544 B
packages/shell/esm-app-shell/dist/4a3e954c45d63305.js 645 B
packages/shell/esm-app-shell/dist/56c2295bc732ae32.js 722 B
packages/shell/esm-app-shell/dist/651172ae1548469c.js 499 B
packages/shell/esm-app-shell/dist/98343ad4bb547c48.js 499 B
packages/shell/esm-app-shell/dist/af598ac97d115dba.js 1.58 kB
packages/shell/esm-app-shell/dist/b5151d35f680b40a.js 3.82 kB
packages/shell/esm-app-shell/dist/ba933133ad512cac.js 499 B
packages/shell/esm-app-shell/dist/dc5587cbc5f783ec.js 6.91 kB
packages/shell/esm-app-shell/dist/fa89289c9d9645c9.js 519 B
packages/shell/esm-app-shell/dist/openmrs.9acc7045cb4d8a14.js 382 kB
packages/shell/esm-app-shell/dist/service-worker.js 45.9 kB
packages/tooling/openmrs/dist/cli.js 2.88 kB
packages/tooling/openmrs/dist/commands/assemble.js 3.21 kB
packages/tooling/openmrs/dist/commands/build.js 1.34 kB
packages/tooling/openmrs/dist/commands/debug.js 545 B
packages/tooling/openmrs/dist/commands/develop.js 2.59 kB
packages/tooling/openmrs/dist/commands/index.js 438 B
packages/tooling/openmrs/dist/commands/start.js 851 B
packages/tooling/openmrs/dist/index.js 517 B
packages/tooling/openmrs/dist/runner.js 637 B
packages/tooling/openmrs/dist/utils/config.js 728 B
packages/tooling/openmrs/dist/utils/debugger.js 576 B
packages/tooling/openmrs/dist/utils/dependencies.js 648 B
packages/tooling/openmrs/dist/utils/helpers.js 395 B
packages/tooling/openmrs/dist/utils/importmap.js 3.07 kB
packages/tooling/openmrs/dist/utils/index.js 444 B
packages/tooling/openmrs/dist/utils/logger.js 368 B
packages/tooling/openmrs/dist/utils/npmConfig.js 830 B
packages/tooling/openmrs/dist/utils/untar.js 722 B
packages/tooling/openmrs/dist/utils/variables.js 192 B
packages/tooling/openmrs/dist/utils/webpack.js 278 B
packages/tooling/webpack-config/dist/index.js 3.61 kB

compressed-size-action

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks, @brandones!

@denniskigen denniskigen merged commit 42affea into main May 29, 2024
11 checks passed
@denniskigen denniskigen deleted the validators-immutable branch May 29, 2024 21:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants