Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(fix) Make download config button in implementer tools fully clickable #957

Merged

Conversation

kb019
Copy link
Contributor

@kb019 kb019 commented Mar 13, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

The Download Config button in the implementer tools downloads a json file only when clicked on the Download Config letters and does not download the file when pressed on the remaining area. Resolved this by capturing the click on the bubbling phase.

Screenshots

Screenshot (297)

@kb019 kb019 changed the title Make download config button in implementer tools fully clickable (fix) Make download config button in implementer tools fully clickable Mar 13, 2024
Copy link
Collaborator

@brandones brandones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you @kb019 !

@brandones brandones merged commit 8435603 into openmrs:main Mar 17, 2024
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants