-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
(fix) O3-3621: Lab test type should not be editable in the lab order form #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +318 B (0%) Total Size: 11.1 MB ℹ️ View Unchanged
|
vasharma05
changed the title
(fix) O3-3621: Selected test type should be visible as text instead of an input
(fix) O3-3621: Lab test type should not be editable in the lab order form
Jul 19, 2024
denniskigen
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @vasharma05.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR changes the input for Test Type in the Lab order form into a text, due to the following issues:
The main perspective behind this is why allow a user to change the test type of an order when that order was meant to be for the selected test.
The idea behind this is similar to how the form is designed in the patient registration, where identifiers which cannot be updated (primary identifier) are shown as text and not as a field.
Screenshots
Screen.Recording.2024-07-19.at.14.29.52.mov
Related Issue
Other