Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(feat) O3-3657: Tweak styling of abnormal results in the vitals header and data tiles #1951

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

Twiineenock
Copy link
Contributor

@Twiineenock Twiineenock commented Aug 5, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

With this PR, we are styling the abnormal and dangerous vital signs within vitals header and widget to have the designs here instead of displaying with a black and red border respectively.

Screenshots

Before:

vitals-before

After:

vitals-redesined

Related Issue

https://openmrs.atlassian.net/browse/O3-3657

Other

@Twiineenock Twiineenock changed the title style abnormal vitals with new designs (feat) O3-3657: Adapt the vitals header and widget to display abnormal results with current designs Aug 5, 2024
@Twiineenock
Copy link
Contributor Author

Hi @denniskigen, I request for a review here.

@denniskigen
Copy link
Member

FYI @ciaranduffy

@denniskigen denniskigen changed the title (feat) O3-3657: Adapt the vitals header and widget to display abnormal results with current designs (feat) O3-3657: Tweak styling of abnormal results in the vitals header and data tiles Aug 6, 2024
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Twiineenock.

@denniskigen denniskigen merged commit f6c4493 into openmrs:main Aug 6, 2024
5 of 6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants