-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
(chore) Conditionally set server-token for CI workflow jobs #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 14.2 MB ℹ️ View Unchanged
|
Per the action author, |
denniskigen
force-pushed
the
chore/optional-server-token
branch
from
August 7, 2024 12:41
bb3daa1
to
68b091c
Compare
ibacher
approved these changes
Aug 7, 2024
NethmiRodrigo
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @denniskigen!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Github Action jobs that depend on remote caching require a
server-token
input. Because forks don't have access to environment variables, workflow runs from PRs made from forks are far slower. Conditionally setting a default value in the case where theserver-token
cannot be obtained is a possible solution to mitigate the slow builds. I'm not too sure though about how this affects security and whether this can be leveraged by bad actors.Screenshots
Related Issue
Other