(test) Amend E2E test for retained inputs in clinical forms workspace #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 14.2 MB ℹ️ View Unchanged
|
|
@denniskigen I see the test failing in GitHub Actions. |
@denniskigen it seems the |
denniskigen
force-pushed
the
test/clinical-forms-retained-inputs
branch
from
9ffd7fd
to
f654af9
Compare
denniskigen
force-pushed
the
test/clinical-forms-retained-inputs
branch
4 times, most recently
from
2e4154e
to
093d22e
Compare
denniskigen
force-pushed
the
test/clinical-forms-retained-inputs
branch
from
093d22e
to
d76a264
Compare
kdaud
reviewed
Aug 12, 2024
| @@ -193,6 +193,7 @@ test('Form state is retained when minimizing a form in the workspace', async ({ | |||
| }); | |||
|
|
|||
| await test.step('And I fill in values for the `White Blood Cells (WBC)`, `Platelets`, and `Neutrophils` questions', async () => { | |||
| await page.locator('#ManualInputWhiteBloodCells').waitFor(); | |||
There was a problem hiding this comment.
@denniskigen waiting for the locator of White Blood Count to load before filling it out seems to prevent data loss.
There was a problem hiding this comment.
I’ve run the GA 4 times, and the test passed each time.
There was a problem hiding this comment.
Yep. Looks like that did the trick! I've run it a couple more times too. Thanks, @kdaud. We should probably document this somewhere.
There was a problem hiding this comment.
IIRC, the same behaviour occurs non-deterministically in the results viewer spec.
There was a problem hiding this comment.
We should probably document this somewhere.
Not sure where to document this.
There was a problem hiding this comment.
That's fine, I'll sort it out. Mind approving the PR?
|
Thanks @denniskigen |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR amends the Clinical Forms E2E test to fix a flaky spec that tests whether form input values are retained when maximizing and minimizing the forms workspace. Here's an example of a test failure with the flaky test. Here's a video showing the test failure from the run:
video.2.webm
It appears that the
White blood cellsinput gets cleared for whatever reason. I've tweaked the locators we're using to access and fill the inputs to use more robust matchers in the hope that that reduces the flakiness of the test. We'll find out soon enough whether this works.Screenshots
Related Issue
Other