Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

(chore) Bump react form engine library #1965

Merged
merged 8 commits into from
Aug 21, 2024
Merged

(chore) Bump react form engine library #1965

merged 8 commits into from
Aug 21, 2024

Conversation

kajambiya
Copy link
Contributor

@kajambiya kajambiya commented Aug 19, 2024 •
edited by denniskigen
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

@samuelmale
Copy link
Member

@kajambiya, I think there’s some lingering residue here.

@kajambiya
Copy link
Contributor Author

@kajambiya, I think there’s some lingering residue here.

Nice catch.
Thanks @samuelmale

@samuelmale
Copy link
Member

@kajambiya do you plan to mark this as ready for review?

@kajambiya kajambiya marked this pull request as ready for review August 20, 2024 03:47
@kajambiya kajambiya force-pushed the BumpFE branch 2 times, most recently from 715ee60 to 4c9b232 Compare August 20, 2024 04:44
@denniskigen
Copy link
Member

@jayasanka-sack do we need to make some mods to the Form Engine library in the test environment here too? Looks like the tests are failing because the content of the success toast they're asserting based on have changed in the latest implementation.

@denniskigen denniskigen changed the title (chore) Bump FE version (chore) Bump react form engine library Aug 20, 2024
jayasanka-sack
jayasanka-sack approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kajambiya! I noticed your PR didn't include the latest changes, so I went ahead and updated it. Also, I simplified the assertions for you. 😉

@jayasanka-sack jayasanka-sack merged commit 627fc0e into openmrs:main Aug 21, 2024
6 checks passed
@kajambiya
Copy link
Contributor Author

Thanks, @kajambiya! I noticed your PR didn't include the latest changes, so I went ahead and updated it. Also, I simplified the assertions for you. 😉

Thanks @jayasanka-sack

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jayasanka-sack jayasanka-sack jayasanka-sack approved these changes

@denniskigen denniskigen Awaiting requested review from denniskigen

@ebambo ebambo Awaiting requested review from ebambo

@samuelmale samuelmale Awaiting requested review from samuelmale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kajambiya @samuelmale @denniskigen @jayasanka-sack