(fix) O3-3622: Allow saving lab reference number with the lab order #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -33 B (0%) Total Size: 14.3 MB ℹ️ View Unchanged
|
|
Hi @vasharma05, the screenshot you added didn't upload, it is reading "uploading...", could check it. |
|
@usamaidrsk , I have added the video recording, thanks! |
|
@denniskigen @usamaidrsk could you review this PR when you get a chance? Thanks! |
usamaidrsk
approved these changes
Aug 26, 2024
|
Any qualms with this approach? @dkayiwa @ibacher @mogoodrich? |
Thanks for copying me in, @denniskigen , sorry I haven't been following all this more closely. Yes, the accession number field is the appropriate place to store a lab reference number... it does seem little odd that we would be collecting that at the time the order was placed (this would seem to be something entered in a fulfillment system?), but if we have a requirement I'm okay with it... maybe make whether it is a field on the order form configurable? |
|
@vasharma05 do we also want to the change the input's label text from |
Often where the accession number is collected depends on where the sample is collected, since it's used to ensure that the correct test(s) are run against the correct sample(s). In some situations, the sample is collected at the clinical point-of-service and sent to the lab; in other situations, the sample is collected at the lab itself. Usually this is determined more by the type of test being ordered and the type of care the patient is receiving. E.g., in US OPD, for example, throat swabs or nasal swabs are likely collected by the clinician or someone working under the clinician's supervision, but blood draws are usually done at the lab; in IPD, samples are usually drawn at the bed; in both the first and third cases, the clinician needs the ability to enter sample reference. |
I'm guessing the wording here was chosen in consultation with clinicians. In any case, I'd make that a separate issue if we want to change the form label. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR allows saving Lab reference number in the
accessionNumberproperty of the order.Screenshots
Screen.Recording.2024-08-22.at.14.07.01.mov
Related Issue
https://issues.openmrs.org/browse/O3-3622
Other