Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(fix) O3-3290: Resolve flickering scroll bar issue in service queues table #1152

Merged

Conversation

Twiineenock
Copy link
Contributor

@Twiineenock Twiineenock commented May 26, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR is aimed at solving this issue.
Service queues table scroll bar appears and disappears on hovering the table
This is demonstrated in the files attached to the issue here

Implemented:

  • vertical and horizontal scrollbars to only appear when content size exceeds table height/width
  • Scrollbars must persist even at hoover states.

Screenshots

after fix:
service-queues#

Related Issue

https://openmrs.atlassian.net/browse/O3-3290

Other

Screancasts

service-queues.webm

Copy link
Contributor

@chibongho chibongho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. I think it would be better if we actually just forgoing the table scrollbar in favor of making the table height longer (and having just one vertical scrollbar for the entire page). Can you change it to that instead?

@Twiineenock
Copy link
Contributor Author

Sorry for the late review. I think it would be better if we actually just forgoing the table scrollbar in favor of making the table height longer (and having just one vertical scrollbar for the entire page). Can you change it to that instead?

@chibongho, I updated this PR to meet this. Thanks!

Copy link
Contributor

@chibongho chibongho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@denniskigen denniskigen changed the title (fiX) O3-3290 : Service queues table scroll bar appears and disappears on hovering the table (fix) O3-3290: Resolve flickering scroll bar issue in service queues table Jun 6, 2024
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks, @Twiineenock!

@denniskigen denniskigen merged commit 8ee7afd into openmrs:main Jun 6, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants