(fix) O3-3199: Service Queues - queue table not updated after transitioning a queue entry #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -51.8 kB (-1.47%) Total Size: 3.47 MB
ℹ️ View Unchanged
|
brandones
commented
Jun 6, 2024
| @@ -41,7 +41,7 @@ describe('Home Component', () => { | |||
| window.location = { pathname: '/some-path/screen' }; | |||
|
|
|||
| render(<Home />); | |||
| expect(screen.getByRole('progressbar')).toBeInTheDocument(); | |||
| expect(screen.getByText(/patients currently in queue/i)).toBeInTheDocument(); | |||
There was a problem hiding this comment.
@donaldkibet I don't really know why this test broke. Could you confirm that I'm not breaking anything that shouldn't be broken?
There was a problem hiding this comment.
Ok, I'll take the thumbs up as meaning "this change seems fine."
chibongho
reviewed
Jun 11, 2024
| if (data && data.length && data?.[data?.length - 1]?.data?.links?.some((link) => link.rel === 'next')) { | ||
| // Calling for the next set of data | ||
| setSize((prev) => prev + 1); | ||
| const nextUrl = getNextUrlFromResponse(pageData); |
There was a problem hiding this comment.
?
Prettier handles things like indentation so we don't have to think about it (and so it can't be wrong)
Co-authored-by: chibongho <cbho@pih.org>
|
@chibongho Per our conversation, I have made it so that tables show data as soon as they get that data, even if more data is still loading. Demo with limit=3 recording-2024-06-12_13.10.07.mp4 |
|
I'll fix the E2E tests soon. Apparently Playwright doesn't support non-LTS Ubuntu, which is nuts. So I guess it's time to upgrade to 24.04. |
|
The E2E tests are failing due to https://openmrs.atlassian.net/browse/O3-3401 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
useSWRInfinitedoes not work withmutate. So I implemented a custom paging SWR hook that supports mutation. I tried writing tests and failed. If we eventually decide to turn this into a more generic paging data hook, we will need to write tests. Also, it retains the original behavior of just downloading all the data at once, iteratively downloading every page.Screenshots
recording-2024-06-06_16.36.51.mp4
Related Issue
https://issues.openmrs.org/browse/O3-3199
Other