(feat) O3-3246 - Ward App - open patient record in workspace #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -5.77 kB (-0.16%) Total Size: 3.51 MB
ℹ️ View Unchanged
|
mseaton
approved these changes
Jul 8, 2024
| onClick={() => | ||
| launchWorkspace<WardPatientWorkspaceProps>('ward-patient-workspace', { patientUuid: props.patient.uuid }) | ||
| }> | ||
| {/* Name will not be displayed; just there for a11y */} |
There was a problem hiding this comment.
Not sure what this means, but ok
There was a problem hiding this comment.
a11y = accessibility. The name serves as a label for the box/button so that the browser knows what it is.
| @@ -0,0 +1,24 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
What is this component for? Is it related to this ticket?
There was a problem hiding this comment.
Oh yeah, stubbed that out before I realized it wasn't asked for in the ticket. Removing it.
| @@ -0,0 +1,18 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
It is unclear if or where this is used here. Is this related to this feature?
There was a problem hiding this comment.
Things with the .extension.tsx suffix are extensions, which are used in the index file. If something has the extension suffix and isn't used in the index file, then something has gone wrong.
|
|
||
| useEffect(() => { | ||
| if (isLoading) { | ||
| setTitle('Ward Patient', <InlineLoading />); |
There was a problem hiding this comment.
This should probably be translated, no? And for the error case below too.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
The skeleton of a patient workspace in the ward app.
Screenshots
I don't know what's going on with the patient info in the cards but it's unrelated to this ticket.
recording-2024-07-03_15.25.13.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-3246
Other