(feat) O3-3244 & O3-3250: Add hook for fetching EMR Configuration #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +33 B (0%) Total Size: 3.91 MB ℹ️ View Unchanged
|
usamaidrsk
approved these changes
Jul 30, 2024
denniskigen
reviewed
Jul 30, 2024
|
|
||
| export default function useEmrConfiguration() { | ||
| const swrData = useSWRImmutable<FetchResponse<EmrApiConfigurationResponse>>( | ||
| `${restBaseUrl}/emrapi/onfiguration`, |
There was a problem hiding this comment.
Suggested change
| `${restBaseUrl}/emrapi/onfiguration`, | |
| `${restBaseUrl}/emrapi/configuration`, |
typo?
There was a problem hiding this comment.
Actually, I was testing failure case and forgot to fix it, I have fixed it now.
Thanks for the catch!
| @@ -275,6 +275,7 @@ | |||
| "ticketNumber": "Ticket Number", | |||
| "time": "Time", | |||
| "timeCannotBeInFuture": "Time cannot be in the future", | |||
| "timeCannotBePriorToPreviousQueueEntry": "Time cannot be before start of previous queue entry: {{time}}", | |||
| "timeOfTransition": "Time of transition", | |||
| "tirageNotYetCompleted": "Triage has not yet been completed", | |||
There was a problem hiding this comment.
Suggested change
| "tirageNotYetCompleted": "Triage has not yet been completed", | |
| "triageNotYetCompleted": "Triage has not yet been completed", |
There was a problem hiding this comment.
Hi @denniskigen!
This change in translation is not related to this PR, the change came up from the extract-translations command. Let me get another PR to improve the key name.
Thanks!
mogoodrich
reviewed
Jul 30, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds a new hook
useEmrConfigurationto fetch the EMR Configuration.Screenshots
None
Related Issue
https://issues.openmrs.org/browse/O3-3244
https://issues.openmrs.org/browse/O3-3250
Other