Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

(test) Assert presence of patient details in patient banner #1286

Merged
merged 9 commits into from
Aug 20, 2024
Merged

(test) Assert presence of patient details in patient banner #1286

merged 9 commits into from
Aug 20, 2024

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Aug 19, 2024 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Extends the "Register a new patient" spec to assert the presence of the newly entered registration data in the patient banner.

Screenshots

Related Issue

Other

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024 •
edited
Loading

Size Change: 0 B

Total Size: 5.83 MB

ℹ️ View Unchanged
Filename Size
packages/esm-active-visits-app/dist/106.js 8.63 kB
packages/esm-active-visits-app/dist/130.js 317 kB
packages/esm-active-visits-app/dist/255.js 2.5 kB
packages/esm-active-visits-app/dist/271.js 800 B
packages/esm-active-visits-app/dist/316.js 42.9 kB
packages/esm-active-visits-app/dist/319.js 709 B
packages/esm-active-visits-app/dist/382.js 1.22 kB
packages/esm-active-visits-app/dist/443.js 6.98 kB
packages/esm-active-visits-app/dist/460.js 824 B
packages/esm-active-visits-app/dist/574.js 615 B
packages/esm-active-visits-app/dist/6.js 26.2 kB
packages/esm-active-visits-app/dist/635.js 1.22 kB
packages/esm-active-visits-app/dist/644.js 800 B
packages/esm-active-visits-app/dist/725.js 643 B
packages/esm-active-visits-app/dist/729.js 3.08 kB
packages/esm-active-visits-app/dist/757.js 721 B
packages/esm-active-visits-app/dist/784.js 2.63 kB
packages/esm-active-visits-app/dist/788.js 628 B
packages/esm-active-visits-app/dist/807.js 959 B
packages/esm-active-visits-app/dist/833.js 765 B
packages/esm-active-visits-app/dist/879.js 3.02 kB
packages/esm-active-visits-app/dist/966.js 51.3 kB
packages/esm-active-visits-app/dist/967.js 611 B
packages/esm-active-visits-app/dist/main.js 81.9 kB
packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js 3.33 kB
packages/esm-appointments-app/dist/130.js 317 kB
packages/esm-appointments-app/dist/152.js 259 B
packages/esm-appointments-app/dist/23.js 14.4 kB
packages/esm-appointments-app/dist/255.js 2.51 kB
packages/esm-appointments-app/dist/265.js 1.79 kB
packages/esm-appointments-app/dist/271.js 2.32 kB
packages/esm-appointments-app/dist/303.js 259 B
packages/esm-appointments-app/dist/319.js 2.15 kB
packages/esm-appointments-app/dist/460.js 2.37 kB
packages/esm-appointments-app/dist/501.js 7.02 kB
packages/esm-appointments-app/dist/574.js 1.94 kB
packages/esm-appointments-app/dist/581.js 9.03 kB
packages/esm-appointments-app/dist/591.js 16.8 kB
packages/esm-appointments-app/dist/644.js 2.32 kB
packages/esm-appointments-app/dist/646.js 250 kB
packages/esm-appointments-app/dist/729.js 3.08 kB
packages/esm-appointments-app/dist/757.js 2.21 kB
packages/esm-appointments-app/dist/784.js 2.62 kB
packages/esm-appointments-app/dist/788.js 1.94 kB
packages/esm-appointments-app/dist/807.js 2.56 kB
packages/esm-appointments-app/dist/833.js 2.3 kB
packages/esm-appointments-app/dist/85.js 30.5 kB
packages/esm-appointments-app/dist/89.js 139 kB
packages/esm-appointments-app/dist/903.js 879 B
packages/esm-appointments-app/dist/main.js 405 kB
packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js 3.39 kB
packages/esm-bed-management-app/dist/130.js 317 kB
packages/esm-bed-management-app/dist/148.js 1.22 kB
packages/esm-bed-management-app/dist/169.js 6.98 kB
packages/esm-bed-management-app/dist/271.js 680 B
packages/esm-bed-management-app/dist/319.js 680 B
packages/esm-bed-management-app/dist/460.js 680 B
packages/esm-bed-management-app/dist/501.js 7.03 kB
packages/esm-bed-management-app/dist/542.js 395 B
packages/esm-bed-management-app/dist/574.js 681 B
packages/esm-bed-management-app/dist/591.js 16.8 kB
packages/esm-bed-management-app/dist/644.js 680 B
packages/esm-bed-management-app/dist/668.js 26.5 kB
packages/esm-bed-management-app/dist/729.js 3.08 kB
packages/esm-bed-management-app/dist/757.js 731 B
packages/esm-bed-management-app/dist/766.js 113 kB
packages/esm-bed-management-app/dist/784.js 2.63 kB
packages/esm-bed-management-app/dist/788.js 680 B
packages/esm-bed-management-app/dist/805.js 50.2 kB
packages/esm-bed-management-app/dist/807.js 680 B
packages/esm-bed-management-app/dist/833.js 680 B
packages/esm-bed-management-app/dist/main.js 3.87 kB
packages/esm-bed-management-app/dist/openmrs-esm-bed-management-app.js 3.25 kB
packages/esm-patient-list-management-app/dist/112.js 63 kB
packages/esm-patient-list-management-app/dist/130.js 317 kB
packages/esm-patient-list-management-app/dist/255.js 2.51 kB
packages/esm-patient-list-management-app/dist/271.js 99.8 kB
packages/esm-patient-list-management-app/dist/319.js 1.51 kB
packages/esm-patient-list-management-app/dist/37.js 8.38 kB
packages/esm-patient-list-management-app/dist/382.js 1.23 kB
packages/esm-patient-list-management-app/dist/384.js 1.58 kB
packages/esm-patient-list-management-app/dist/443.js 6.98 kB
packages/esm-patient-list-management-app/dist/460.js 1.72 kB
packages/esm-patient-list-management-app/dist/574.js 1.34 kB
packages/esm-patient-list-management-app/dist/591.js 16.9 kB
packages/esm-patient-list-management-app/dist/635.js 1.23 kB
packages/esm-patient-list-management-app/dist/644.js 1.58 kB
packages/esm-patient-list-management-app/dist/729.js 3.08 kB
packages/esm-patient-list-management-app/dist/757.js 1.58 kB
packages/esm-patient-list-management-app/dist/784.js 2.63 kB
packages/esm-patient-list-management-app/dist/788.js 1.34 kB
packages/esm-patient-list-management-app/dist/807.js 1.85 kB
packages/esm-patient-list-management-app/dist/833.js 1.59 kB
packages/esm-patient-list-management-app/dist/main.js 167 kB
packages/esm-patient-list-management-app/dist/openmrs-esm-patient-list-management-app.js 3.31 kB
packages/esm-patient-registration-app/dist/130.js 317 kB
packages/esm-patient-registration-app/dist/152.js 264 B
packages/esm-patient-registration-app/dist/169.js 6.71 kB
packages/esm-patient-registration-app/dist/255.js 2.5 kB
packages/esm-patient-registration-app/dist/271.js 2.13 kB
packages/esm-patient-registration-app/dist/290.js 61.6 kB
packages/esm-patient-registration-app/dist/303.js 264 B
packages/esm-patient-registration-app/dist/319.js 2.05 kB
packages/esm-patient-registration-app/dist/371.js 547 B
packages/esm-patient-registration-app/dist/460.js 2.22 kB
packages/esm-patient-registration-app/dist/501.js 7.03 kB
packages/esm-patient-registration-app/dist/540.js 67.4 kB
packages/esm-patient-registration-app/dist/574.js 1.78 kB
packages/esm-patient-registration-app/dist/591.js 16.8 kB
packages/esm-patient-registration-app/dist/623.js 6.19 kB
packages/esm-patient-registration-app/dist/644.js 2.13 kB
packages/esm-patient-registration-app/dist/729.js 3.08 kB
packages/esm-patient-registration-app/dist/735.js 465 B
packages/esm-patient-registration-app/dist/757.js 2.15 kB
packages/esm-patient-registration-app/dist/784.js 2.63 kB
packages/esm-patient-registration-app/dist/788.js 1.78 kB
packages/esm-patient-registration-app/dist/807.js 2.51 kB
packages/esm-patient-registration-app/dist/833.js 2.06 kB
packages/esm-patient-registration-app/dist/879.js 3.03 kB
packages/esm-patient-registration-app/dist/main.js 131 kB
packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js 3.35 kB
packages/esm-patient-search-app/dist/130.js 317 kB
packages/esm-patient-search-app/dist/255.js 2.5 kB
packages/esm-patient-search-app/dist/271.js 920 B
packages/esm-patient-search-app/dist/319.js 861 B
packages/esm-patient-search-app/dist/382.js 1.23 kB
packages/esm-patient-search-app/dist/420.js 22.4 kB
packages/esm-patient-search-app/dist/443.js 6.98 kB
packages/esm-patient-search-app/dist/460.js 939 B
packages/esm-patient-search-app/dist/574.js 742 B
packages/esm-patient-search-app/dist/591.js 16.8 kB
packages/esm-patient-search-app/dist/634.js 52 kB
packages/esm-patient-search-app/dist/635.js 1.23 kB
packages/esm-patient-search-app/dist/644.js 920 B
packages/esm-patient-search-app/dist/729.js 3.08 kB
packages/esm-patient-search-app/dist/757.js 871 B
packages/esm-patient-search-app/dist/784.js 2.63 kB
packages/esm-patient-search-app/dist/788.js 736 B
packages/esm-patient-search-app/dist/807.js 1.04 kB
packages/esm-patient-search-app/dist/833.js 877 B
packages/esm-patient-search-app/dist/main.js 77.4 kB
packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js 3.3 kB
packages/esm-service-queues-app/dist/130.js 317 kB
packages/esm-service-queues-app/dist/152.js 261 B
packages/esm-service-queues-app/dist/169.js 6.98 kB
packages/esm-service-queues-app/dist/199.js 1.35 kB
packages/esm-service-queues-app/dist/236.js 5.84 kB
packages/esm-service-queues-app/dist/255.js 2.51 kB
packages/esm-service-queues-app/dist/265.js 118 kB
packages/esm-service-queues-app/dist/271.js 4.56 kB
packages/esm-service-queues-app/dist/282.js 8.97 kB
packages/esm-service-queues-app/dist/303.js 261 B
packages/esm-service-queues-app/dist/319.js 3.86 kB
packages/esm-service-queues-app/dist/366.js 7.86 kB
packages/esm-service-queues-app/dist/392.js 7.85 kB
packages/esm-service-queues-app/dist/460.js 4.78 kB
packages/esm-service-queues-app/dist/484.js 158 kB
packages/esm-service-queues-app/dist/501.js 7.03 kB
packages/esm-service-queues-app/dist/574.js 3.85 kB
packages/esm-service-queues-app/dist/591.js 16.8 kB
packages/esm-service-queues-app/dist/6.js 1.75 kB
packages/esm-service-queues-app/dist/604.js 6.96 kB
packages/esm-service-queues-app/dist/644.js 4.57 kB
packages/esm-service-queues-app/dist/670.js 10 kB
packages/esm-service-queues-app/dist/727.js 8.1 kB
packages/esm-service-queues-app/dist/729.js 3.08 kB
packages/esm-service-queues-app/dist/752.js 1.62 kB
packages/esm-service-queues-app/dist/757.js 4.14 kB
packages/esm-service-queues-app/dist/760.js 7.13 kB
packages/esm-service-queues-app/dist/784.js 2.63 kB
packages/esm-service-queues-app/dist/788.js 3.86 kB
packages/esm-service-queues-app/dist/800.js 1.68 kB
packages/esm-service-queues-app/dist/807.js 5.14 kB
packages/esm-service-queues-app/dist/818.js 2.55 kB
packages/esm-service-queues-app/dist/828.js 1.39 kB
packages/esm-service-queues-app/dist/833.js 4.46 kB
packages/esm-service-queues-app/dist/911.js 7.76 kB
packages/esm-service-queues-app/dist/940.js 21.4 kB
packages/esm-service-queues-app/dist/main.js 278 kB
packages/esm-service-queues-app/dist/openmrs-esm-service-queues-app.js 3.31 kB
packages/esm-ward-app/dist/130.js 317 kB
packages/esm-ward-app/dist/152.js 255 B
packages/esm-ward-app/dist/169.js 6.97 kB
packages/esm-ward-app/dist/255.js 2.5 kB
packages/esm-ward-app/dist/269.js 779 B
packages/esm-ward-app/dist/303.js 255 B
packages/esm-ward-app/dist/348.js 349 B
packages/esm-ward-app/dist/466.js 363 B
packages/esm-ward-app/dist/501.js 7.02 kB
packages/esm-ward-app/dist/574.js 1.28 kB
packages/esm-ward-app/dist/577.js 18 kB
packages/esm-ward-app/dist/591.js 16.8 kB
packages/esm-ward-app/dist/659.js 9.78 kB
packages/esm-ward-app/dist/689.js 32.3 kB
packages/esm-ward-app/dist/729.js 3.07 kB
packages/esm-ward-app/dist/749.js 8.12 kB
packages/esm-ward-app/dist/76.js 4.96 kB
packages/esm-ward-app/dist/767.js 648 B
packages/esm-ward-app/dist/784.js 2.62 kB
packages/esm-ward-app/dist/803.js 13.9 kB
packages/esm-ward-app/dist/888.js 28.9 kB
packages/esm-ward-app/dist/940.js 21.4 kB
packages/esm-ward-app/dist/960.js 342 B
packages/esm-ward-app/dist/main.js 64.4 kB
packages/esm-ward-app/dist/openmrs-esm-ward-app.js 3.3 kB

compressed-size-action

@denniskigen denniskigen force-pushed the test/extend-patient-registration-spec branch 3 times, most recently from 9c71181 to 903560f Compare August 19, 2024 11:28
@denniskigen
Copy link
Member Author

@kdaud mind helping me out here? I can't get the page to wait for the banner to get rendered.

@denniskigen denniskigen force-pushed the test/extend-patient-registration-spec branch from 903560f to 0d5b738 Compare August 19, 2024 12:33
@denniskigen denniskigen force-pushed the test/extend-patient-registration-spec branch 3 times, most recently from 416098c to 01fd240 Compare August 19, 2024 18:02
@denniskigen denniskigen force-pushed the test/extend-patient-registration-spec branch from c0836c6 to 3f3822e Compare August 19, 2024 18:17
@denniskigen denniskigen force-pushed the test/extend-patient-registration-spec branch 4 times, most recently from 8435309 to f5d3c96 Compare August 19, 2024 20:37
@denniskigen denniskigen force-pushed the test/extend-patient-registration-spec branch from f5d3c96 to 66ca872 Compare August 19, 2024 20:48
@jayasanka-sack
Copy link
Member

@denniskigen, after watching the video I noticed it's failing because it isn't loading any content. I've added the patient banner app to the environment. so it should be good now.

jayasanka-sack
jayasanka-sack reviewed Aug 20, 2024
View reviewed changes
@denniskigen denniskigen force-pushed the test/extend-patient-registration-spec branch from 7d4bd37 to 3a2d90e Compare August 20, 2024 10:43
@denniskigen denniskigen requested a review from ibacher August 20, 2024 17:07
@denniskigen denniskigen merged commit 87de528 into main Aug 20, 2024
6 checks passed
@denniskigen denniskigen deleted the test/extend-patient-registration-spec branch August 20, 2024 17:29
@denniskigen denniskigen mentioned this pull request Aug 29, 2024
Merged
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ibacher ibacher ibacher approved these changes

@kdaud kdaud Awaiting requested review from kdaud

@jayasanka-sack jayasanka-sack Awaiting requested review from jayasanka-sack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denniskigen @jayasanka-sack @ibacher