Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

(feat) Try to minimize the number of dynamic imports #872

Merged
merged 2 commits into from
Nov 3, 2023
Merged

(feat) Try to minimize the number of dynamic imports #872

merged 2 commits into from
Nov 3, 2023

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Nov 3, 2023

Requirements

Summary

The goal here is to have fewer dynamic imports, and thus fewer chunks that need to be downloaded. This isn't quite the changes I was hoping for, but it seems to eliminate about 13 requests for JS files.

Screenshots

None.

Related Issue

None.

Other

None.

denniskigen
denniskigen approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ibacher!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Size Change: -21.2 kB (-1%)

Total Size: 3.16 MB

Filename Size Change
packages/esm-active-visits-app/dist/459.js 0 B -50.1 kB (removed) 🏆
packages/esm-active-visits-app/dist/629.js 50.9 kB +43.2 kB (+566%) 🆘
packages/esm-active-visits-app/dist/main.js 67.6 kB +64.1 kB (+1822%) 🆘
packages/esm-appointments-app/dist/202.js 0 B -11.2 kB (removed) 🏆
packages/esm-appointments-app/dist/23.js 0 B -12.6 kB (removed) 🏆
packages/esm-appointments-app/dist/315.js 0 B -140 kB (removed) 🏆
packages/esm-appointments-app/dist/435.js 0 B -11.1 kB (removed) 🏆
packages/esm-appointments-app/dist/542.js 0 B -93.9 kB (removed) 🏆
packages/esm-appointments-app/dist/722.js 0 B -10.8 kB (removed) 🏆
packages/esm-appointments-app/dist/818.js 0 B -10.8 kB (removed) 🏆
packages/esm-appointments-app/dist/main.js 298 kB +292 kB (+5115%) 🆘
packages/esm-patient-list-app/dist/795.js 0 B -14.6 kB (removed) 🏆
packages/esm-patient-list-app/dist/975.js 0 B -98.1 kB (removed) 🏆
packages/esm-patient-list-app/dist/main.js 129 kB +125 kB (+3154%) 🆘
packages/esm-patient-registration-app/dist/240.js 0 B -26.2 kB (removed) 🏆
packages/esm-patient-registration-app/dist/294.js 0 B -23.4 kB (removed) 🏆
packages/esm-patient-registration-app/dist/491.js 0 B -28.9 kB (removed) 🏆
packages/esm-patient-registration-app/dist/794.js 0 B -27.2 kB (removed) 🏆
packages/esm-patient-registration-app/dist/975.js 35.1 kB +34.7 kB (+8159%) 🆘
packages/esm-patient-registration-app/dist/main.js 123 kB +103 kB (+524%) 🆘
packages/esm-patient-search-app/dist/110.js 0 B -17 kB (removed) 🏆
packages/esm-patient-search-app/dist/474.js 0 B -24.9 kB (removed) 🏆
packages/esm-patient-search-app/dist/main.js 54.1 kB +50.5 kB (+1395%) 🆘
packages/esm-service-queues-app/dist/433.js 0 B -25.7 kB (removed) 🏆
packages/esm-service-queues-app/dist/582.js 0 B -151 kB (removed) 🏆
packages/esm-service-queues-app/dist/main.js 218 kB +214 kB (+5150%) 🆘
ℹ️ View Unchanged
Filename Size Change
packages/esm-active-visits-app/dist/130.js 172 kB +14 B (0%)
packages/esm-active-visits-app/dist/255.js 2.21 kB -2 B (0%)
packages/esm-active-visits-app/dist/277.js 12.3 kB 0 B
packages/esm-active-visits-app/dist/316.js 42.9 kB 0 B
packages/esm-active-visits-app/dist/319.js 631 B 0 B
packages/esm-active-visits-app/dist/382.js 1.15 kB -2 B (0%)
packages/esm-active-visits-app/dist/403.js 0 B -7.16 kB (removed) 🏆
packages/esm-active-visits-app/dist/460.js 727 B 0 B
packages/esm-active-visits-app/dist/574.js 553 B 0 B
packages/esm-active-visits-app/dist/588.js 6.66 kB 0 B
packages/esm-active-visits-app/dist/635.js 1.15 kB -2 B (0%)
packages/esm-active-visits-app/dist/729.js 3.1 kB 0 B
packages/esm-active-visits-app/dist/757.js 649 B 0 B
packages/esm-active-visits-app/dist/784.js 2.63 kB 0 B
packages/esm-active-visits-app/dist/788.js 551 B 0 B
packages/esm-active-visits-app/dist/807.js 864 B 0 B
packages/esm-active-visits-app/dist/833.js 669 B 0 B
packages/esm-active-visits-app/dist/842.js 0 B -900 B (removed) 🏆
packages/esm-active-visits-app/dist/879.js 2.94 kB 0 B
packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js 3.33 kB +3 B (0%)
packages/esm-appointments-app/dist/130.js 172 kB +13 B (0%)
packages/esm-appointments-app/dist/152.js 257 B -4 B (-2%)
packages/esm-appointments-app/dist/255.js 2.23 kB -2 B (0%)
packages/esm-appointments-app/dist/303.js 258 B -2 B (-1%)
packages/esm-appointments-app/dist/319.js 1.95 kB 0 B
packages/esm-appointments-app/dist/334.js 0 B -542 B (removed) 🏆
packages/esm-appointments-app/dist/345.js 244 kB 0 B
packages/esm-appointments-app/dist/403.js 0 B -1.96 kB (removed) 🏆
packages/esm-appointments-app/dist/44.js 0 B -2.92 kB (removed) 🏆
packages/esm-appointments-app/dist/460.js 2.16 kB 0 B
packages/esm-appointments-app/dist/469.js 6.65 kB 0 B
packages/esm-appointments-app/dist/547.js 0 B -4.68 kB (removed) 🏆
packages/esm-appointments-app/dist/551.js 0 B -5.74 kB (removed) 🏆
packages/esm-appointments-app/dist/574.js 1.74 kB 0 B
packages/esm-appointments-app/dist/591.js 16.9 kB 0 B
packages/esm-appointments-app/dist/610.js 6.71 kB +4 B (0%)
packages/esm-appointments-app/dist/690.js 49.9 kB 0 B
packages/esm-appointments-app/dist/729.js 3.1 kB 0 B
packages/esm-appointments-app/dist/757.js 1.73 kB 0 B
packages/esm-appointments-app/dist/772.js 0 B -4.66 kB (removed) 🏆
packages/esm-appointments-app/dist/784.js 2.63 kB 0 B
packages/esm-appointments-app/dist/788.js 1.73 kB 0 B
packages/esm-appointments-app/dist/80.js 2.52 kB -2.58 kB (-51%) 🏆
packages/esm-appointments-app/dist/800.js 0 B -616 B (removed) 🏆
packages/esm-appointments-app/dist/807.js 2.39 kB 0 B
packages/esm-appointments-app/dist/833.js 2.03 kB 0 B
packages/esm-appointments-app/dist/890.js 0 B -568 B (removed) 🏆
packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js 3.29 kB +4 B (0%)
packages/esm-patient-list-app/dist/130.js 172 kB +13 B (0%)
packages/esm-patient-list-app/dist/255.js 2.21 kB -2 B (0%)
packages/esm-patient-list-app/dist/294.js 0 B -5.72 kB (removed) 🏆
packages/esm-patient-list-app/dist/319.js 1.32 kB 0 B
packages/esm-patient-list-app/dist/366.js 105 kB 0 B
packages/esm-patient-list-app/dist/37.js 0 B -1.52 kB (removed) 🏆
packages/esm-patient-list-app/dist/373.js 20.7 kB 0 B
packages/esm-patient-list-app/dist/382.js 1.14 kB -1 B (0%)
packages/esm-patient-list-app/dist/460.js 1.49 kB 0 B
packages/esm-patient-list-app/dist/537.js 0 B -534 B (removed) 🏆
packages/esm-patient-list-app/dist/565.js 0 B -2.65 kB (removed) 🏆
packages/esm-patient-list-app/dist/574.js 1.14 kB 0 B
packages/esm-patient-list-app/dist/588.js 6.66 kB 0 B
packages/esm-patient-list-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-list-app/dist/635.js 1.14 kB -2 B (0%)
packages/esm-patient-list-app/dist/646.js 0 B -2.29 kB (removed) 🏆
packages/esm-patient-list-app/dist/716.js 4.62 kB 0 B
packages/esm-patient-list-app/dist/729.js 3.1 kB 0 B
packages/esm-patient-list-app/dist/757.js 1.3 kB 0 B
packages/esm-patient-list-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-list-app/dist/788.js 1.14 kB 0 B
packages/esm-patient-list-app/dist/791.js 0 B -1.53 kB (removed) 🏆
packages/esm-patient-list-app/dist/807.js 1.64 kB 0 B
packages/esm-patient-list-app/dist/833.js 1.36 kB 0 B
packages/esm-patient-list-app/dist/970.js 0 B -5.96 kB (removed) 🏆
packages/esm-patient-list-app/dist/openmrs-esm-patient-list-app.js 3.29 kB -2 B (0%)
packages/esm-patient-registration-app/dist/130.js 172 kB +13 B (0%)
packages/esm-patient-registration-app/dist/152.js 262 B -3 B (-1%)
packages/esm-patient-registration-app/dist/255.js 2.21 kB -2 B (0%)
packages/esm-patient-registration-app/dist/303.js 260 B -3 B (-1%)
packages/esm-patient-registration-app/dist/319.js 1.75 kB 0 B
packages/esm-patient-registration-app/dist/326.js 85.5 kB 0 B
packages/esm-patient-registration-app/dist/37.js 0 B -2.08 kB (removed) 🏆
packages/esm-patient-registration-app/dist/460.js 1.82 kB 0 B
packages/esm-patient-registration-app/dist/537.js 2.3 kB -1.44 kB (-39%) 🎉
packages/esm-patient-registration-app/dist/574.js 1.49 kB 0 B
packages/esm-patient-registration-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-registration-app/dist/62.js 6.86 kB +4 B (0%)
packages/esm-patient-registration-app/dist/631.js 0 B -7.96 kB (removed) 🏆
packages/esm-patient-registration-app/dist/635.js 0 B -456 B (removed) 🏆
packages/esm-patient-registration-app/dist/68.js 0 B -9.65 kB (removed) 🏆
packages/esm-patient-registration-app/dist/729.js 3.1 kB 0 B
packages/esm-patient-registration-app/dist/735.js 464 B 0 B
packages/esm-patient-registration-app/dist/742.js 0 B -720 B (removed) 🏆
packages/esm-patient-registration-app/dist/757.js 1.77 kB 0 B
packages/esm-patient-registration-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-registration-app/dist/788.js 1.42 kB 0 B
packages/esm-patient-registration-app/dist/807.js 2.22 kB 0 B
packages/esm-patient-registration-app/dist/833.js 1.74 kB 0 B
packages/esm-patient-registration-app/dist/879.js 2.94 kB 0 B
packages/esm-patient-registration-app/dist/884.js 6.1 kB 0 B
packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js 3.33 kB -19 B (-1%)
packages/esm-patient-search-app/dist/128.js 0 B -2.01 kB (removed) 🏆
packages/esm-patient-search-app/dist/130.js 172 kB +12 B (0%)
packages/esm-patient-search-app/dist/152.js 261 B -3 B (-1%)
packages/esm-patient-search-app/dist/174.js 0 B -1.6 kB (removed) 🏆
packages/esm-patient-search-app/dist/255.js 2.21 kB -3 B (0%)
packages/esm-patient-search-app/dist/303.js 260 B -3 B (-1%)
packages/esm-patient-search-app/dist/319.js 936 B 0 B
packages/esm-patient-search-app/dist/327.js 0 B -1.06 kB (removed) 🏆
packages/esm-patient-search-app/dist/357.js 0 B -5.69 kB (removed) 🏆
packages/esm-patient-search-app/dist/382.js 1.15 kB -2 B (0%)
packages/esm-patient-search-app/dist/460.js 1.06 kB 0 B
packages/esm-patient-search-app/dist/519.js 0 B -5.08 kB (removed) 🏆
packages/esm-patient-search-app/dist/574.js 781 B 0 B
packages/esm-patient-search-app/dist/588.js 6.66 kB 0 B
packages/esm-patient-search-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-search-app/dist/635.js 1.15 kB -2 B (0%)
packages/esm-patient-search-app/dist/729.js 3.1 kB 0 B
packages/esm-patient-search-app/dist/757.js 938 B 0 B
packages/esm-patient-search-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-search-app/dist/788.js 776 B 0 B
packages/esm-patient-search-app/dist/807.js 1.11 kB 0 B
packages/esm-patient-search-app/dist/832.js 26 kB 0 B
packages/esm-patient-search-app/dist/833.js 951 B 0 B
packages/esm-patient-search-app/dist/842.js 0 B -2.08 kB (removed) 🏆
packages/esm-patient-search-app/dist/853.js 24.9 kB 0 B
packages/esm-patient-search-app/dist/939.js 0 B -4.4 kB (removed) 🏆
packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js 3.34 kB 0 B
packages/esm-service-queues-app/dist/130.js 172 kB +13 B (0%)
packages/esm-service-queues-app/dist/152.js 262 B -2 B (-1%)
packages/esm-service-queues-app/dist/176.js 0 B -5.76 kB (removed) 🏆
packages/esm-service-queues-app/dist/242.js 0 B -219 B (removed) 🏆
packages/esm-service-queues-app/dist/255.js 2.23 kB -2 B (0%)
packages/esm-service-queues-app/dist/286.js 0 B -2.87 kB (removed) 🏆
packages/esm-service-queues-app/dist/303.js 261 B -3 B (-1%)
packages/esm-service-queues-app/dist/308.js 0 B -8.15 kB (removed) 🏆
packages/esm-service-queues-app/dist/311.js 0 B -4.19 kB (removed) 🏆
packages/esm-service-queues-app/dist/315.js 0 B -1.16 kB (removed) 🏆
packages/esm-service-queues-app/dist/319.js 3.15 kB 0 B
packages/esm-service-queues-app/dist/328.js 3.08 kB 0 B
packages/esm-service-queues-app/dist/330.js 0 B -8.6 kB (removed) 🏆
packages/esm-service-queues-app/dist/366.js 0 B -2.14 kB (removed) 🏆
packages/esm-service-queues-app/dist/398.js 0 B -2.03 kB (removed) 🏆
packages/esm-service-queues-app/dist/425.js 2.06 kB -1.35 kB (-40%) 🎉
packages/esm-service-queues-app/dist/457.js 0 B -2.5 kB (removed) 🏆
packages/esm-service-queues-app/dist/460.js 3.98 kB 0 B
packages/esm-service-queues-app/dist/469.js 6.66 kB 0 B
packages/esm-service-queues-app/dist/51.js 53.9 kB 0 B
packages/esm-service-queues-app/dist/53.js 0 B -3.11 kB (removed) 🏆
packages/esm-service-queues-app/dist/574.js 3.15 kB 0 B
packages/esm-service-queues-app/dist/591.js 16.9 kB 0 B
packages/esm-service-queues-app/dist/610.js 6.71 kB +4 B (0%)
packages/esm-service-queues-app/dist/616.js 2.7 kB -910 B (-25%) 🎉
packages/esm-service-queues-app/dist/617.js 0 B -4.07 kB (removed) 🏆
packages/esm-service-queues-app/dist/627.js 0 B -2.94 kB (removed) 🏆
packages/esm-service-queues-app/dist/680.js 0 B -2.54 kB (removed) 🏆
packages/esm-service-queues-app/dist/719.js 0 B -5.39 kB (removed) 🏆
packages/esm-service-queues-app/dist/729.js 3.1 kB 0 B
packages/esm-service-queues-app/dist/733.js 3.93 kB 0 B
packages/esm-service-queues-app/dist/757.js 3.15 kB 0 B
packages/esm-service-queues-app/dist/764.js 0 B -5.19 kB (removed) 🏆
packages/esm-service-queues-app/dist/766.js 0 B -4.74 kB (removed) 🏆
packages/esm-service-queues-app/dist/784.js 2.63 kB 0 B
packages/esm-service-queues-app/dist/788.js 3.13 kB 0 B
packages/esm-service-queues-app/dist/794.js 161 kB 0 B
packages/esm-service-queues-app/dist/807.js 4.38 kB 0 B
packages/esm-service-queues-app/dist/833.js 3.75 kB 0 B
packages/esm-service-queues-app/dist/86.js 2.43 kB -1.97 kB (-45%) 🎉
packages/esm-service-queues-app/dist/944.js 0 B -2.77 kB (removed) 🏆
packages/esm-service-queues-app/dist/981.js 2.94 kB -697 B (-19%) 👏
packages/esm-service-queues-app/dist/openmrs-esm-service-queues-app.js 3.31 kB +10 B (0%)

compressed-size-action

@denniskigen denniskigen merged commit ca50ae6 into main Nov 3, 2023
@denniskigen denniskigen deleted the feat/fewer-webpack-chunks branch November 3, 2023 19:37
@denniskigen denniskigen mentioned this pull request Jan 27, 2025
Merged
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

@vasharma05 vasharma05 Awaiting requested review from vasharma05

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibacher @denniskigen