Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

OCLOMRS-1016: Add support for selecting concepts from custom sources to the Bulk Import feature. #768

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

hadijahkyampeire
Copy link
Collaborator

@hadijahkyampeire hadijahkyampeire commented Jan 24, 2022

JIRA TICKET NAME:

Add support for selecting concepts from custom sources to the Bulk Import feature

Summary:

  • Implement the showing of all sources when doing bulk import.

Caveat

  • We shall need to do some refactoring and unifying of the code once the other PR with the same work.
  • Did not technically use InfinteScroll because of its constraints but used some other technique of paginating that is almost like it.

@hadijahkyampeire
Copy link
Collaborator Author

@jwnasambu please look at my PR and see what you think about how I load more sources.

@coveralls
Copy link

coveralls commented Jan 24, 2022

Coverage Status

Coverage decreased (-0.8%) to 45.709% when pulling cdd0bf6 on hadijahkyampeire:OCLOMRS-1016 into 72e7409 on openmrs:master.

@hadijahkyampeire
Copy link
Collaborator Author

@suruchee and @ibacher please review my PR for this work. Thanks.

Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few thoughts on this, but overall good work @hadijahkyampeire!

@hadijahkyampeire
Copy link
Collaborator Author

Thanks, @ibacher for the review I will work on it and get back to you on what I don't understand.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants