[Bug] Concurrent requests with the cloudflare wrappers

[vicb]

There is a bug when using the cloudflare wrappers (cloudflare-node and cloudflare-edge)

It will manifest with the following log:

workerd/io/worker.c++:1195: warning: NOSENTRY Warning: Cross Request Promise Resolve

The root cause is that we share ctx.waitUntil() on globalThis.openNextWaitUntil:

globalThis.openNextWaitUntil = ctx.waitUntil.bind(ctx);

The problem here is that ctx.waitUntil is request specific but globalThis is shared across requests. We should add it to ALS instead.

I hope I'll get to fixing this later today, otherwise in the next few days.

Edit: the warning has been removed from workerd in cloudflare/workerd#3388, you need to run the e2e with workerd v1.20250121.0 to see the warning

[conico974]

Hmm i see, not sure we can easily reuse the current OpenNext ALS without some breaking change. Reusing it probably means that we'd have to initialize the ALS on every wrapper and that's not something that i'd like to do.

Maybe it would make sense to define the cloudflare context inside the wrapper directly ?
Another option would be to create one ALS only if you can't find the already defined one (i.e. (globalThis as any)[Symbol.for("__cloudflare-context__")])