Skip to content

Pass revalidate value to the incremental cache for ISR/SSG route #833

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Apr 29, 2025

Conversation

conico974
Copy link
Contributor

This PR will compute the correct revalidate value at runtime for ISR/SSG route to be used by the incremental cache

It depends on #832, just to avoid deleting and recreating a cloudfront distribution every time i switch branch.
I'll rebased #820 on this as well

@conico974 conico974 mentioned this pull request Apr 16, 2025
@conico974 conico974 force-pushed the feat/compute-revalidate-cache branch from d453e0c to 48c5da6 Compare April 18, 2025 11:43
Copy link

changeset-bot bot commented Apr 18, 2025

🦋 Changeset detected

Latest commit: ade16e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@conico974 conico974 requested a review from vicb April 28, 2025 14:25
Base automatically changed from test/experimental-e2e to main April 29, 2025 08:18
@conico974 conico974 force-pushed the feat/compute-revalidate-cache branch from 48c5da6 to ade16e1 Compare April 29, 2025 08:30
Copy link

pkg-pr-new bot commented Apr 29, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@833

commit: ade16e1

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 26.61% 2479 / 9315
🔵 Statements 26.61% 2479 / 9315
🔵 Functions 52.84% 130 / 246
🔵 Branches 73.17% 600 / 820
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/adapters/cache.ts 85.71% 82.3% 100% 85.71% 20-21, 80-82, 85-94, 151-162, 184-185, 368-376, 410-411, 445-454, 464-472
packages/open-next/src/types/cache.ts 0% 0% 0% 0%
packages/open-next/src/types/overrides.ts 0% 0% 0% 0%
Generated in workflow #1172 for commit ade16e1 by the Vitest Coverage Report Action

@conico974 conico974 merged commit 3b979a2 into main Apr 29, 2025
3 checks passed
@conico974 conico974 deleted the feat/compute-revalidate-cache branch April 29, 2025 08:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants