Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding initiateExchange EP to client lib #22

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

brandonrobinson5060
Copy link
Contributor

Client lib didn't have initiateExchange endpoint on api v2. Adding it here

@lylepratt
Copy link

Would be good if you guys could merge this! We're using your Node client, but it does not have support for the exchange API so @brandonrobinson5060 added it.

Copy link
Member

@johnnyasantoss johnnyasantoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just added a question on reusing the current axios client.

submodules/client.js Show resolved Hide resolved
Copy link
Member

@johnnyasantoss johnnyasantoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

submodules/client.js Show resolved Hide resolved
@brandonrobinson5060
Copy link
Contributor Author

Hey there @johnnyasantoss - hope all is well. Not sure how often you guys merge/deploy but was just wondering if we could get this merged soon. Thanks!

@ruigomeseu ruigomeseu merged commit da26ca9 into opennodedev:master Sep 15, 2022
@johnnyasantoss
Copy link
Member

Hey there @johnnyasantoss - hope all is well. Not sure how often you guys merge/deploy but was just wondering if we could get this merged soon. Thanks!

It's published as 1.4.0. Thank you for your contribution!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants