Skip to content

Commit

Permalink
target: free private_config if target initialisation fails
Browse files Browse the repository at this point in the history
Fixes private_config memory leak when xx_deinit_target() is not called

Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Change-Id: Ie7cce7f24af24695e7d2c1cd1882474c6863b80d
Reviewed-on: https://review.openocd.org/c/openocd/+/8642
Tested-by: jenkins
Reviewed-by: zapb <dev@zapb.de>
Reviewed-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
  • Loading branch information
tom-van committed Jan 9, 2025
1 parent cf115c1 commit d4b3b4e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/target/target.c
Original file line number Diff line number Diff line change
Expand Up @@ -5848,6 +5848,7 @@ static int target_create(struct jim_getopt_info *goi)
free(target->gdb_port_override);
free(target->trace_info);
free(target->type);
free(target->private_config);
free(target);
return e;
}
Expand All @@ -5865,6 +5866,7 @@ static int target_create(struct jim_getopt_info *goi)
free(target->gdb_port_override);
free(target->trace_info);
free(target->type);
free(target->private_config);
free(target);
return JIM_ERR;
}
Expand All @@ -5878,6 +5880,7 @@ static int target_create(struct jim_getopt_info *goi)
free(target->gdb_port_override);
free(target->trace_info);
free(target->type);
free(target->private_config);
free(target);
return JIM_ERR;
}
Expand Down

0 comments on commit d4b3b4e

Please # to comment.