Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

improve: removed the superfluous header type check #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improve: removed the superfluous header type check #49

wants to merge 1 commit into from

Conversation

tokers
Copy link

@tokers tokers commented Feb 17, 2019

The ngx.var API only returns a Lua string in case of success or nil if
failure. So check whether the header is a Lua table is superfluous.

@tokers
improve: removed the superfluous header type check
4f3fd0f 
The ngx.var API only returns a Lua string in case of success or `nil` if
failure. So check whether the header is a Lua table is superfluous.
@agentzh
Copy link
Member

agentzh commented Feb 17, 2019

@tokers Yeah, we used to use ngx.req.get_headers() to fetch the Content-Type header, but we did not remove the table type check after switching to ngx.var. This patch looks good to me.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@agentzh agentzh agentzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tokers @agentzh