Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Chore: Upgrade client packages #66

Merged
merged 9 commits into from
Nov 15, 2024
Merged

Conversation

carlosmondra
Copy link
Member

@carlosmondra carlosmondra commented Nov 12, 2024

This PR:

  • Upgrade to use Node 22. We will still use Node 20 until we finalize migration
  • Upgrades the client packages to be more compatible with Node 22. The punycode deprecation notice is still showing up because of eslint.
  • Upgrade to mongo 7
  • Remove legacy eslint code
  • Add retries to flaky tests

@carlosmondra carlosmondra force-pushed the feature/upgrade-packages branch from bd28c64 to a0497cf Compare November 13, 2024 21:14
@carlosmondra carlosmondra force-pushed the feature/upgrade-packages branch from a0497cf to 7161648 Compare November 13, 2024 21:42
this.skip();
this.retries(3);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is not required as the test is skipped

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I removed it

@xkopenreview xkopenreview merged commit f1efe78 into master Nov 15, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants