Throwing SyntaxError if a parsed source file is syntactically incorrect #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a source file has syntax errors, the ParseError is generated, and the file is skipped from parsing. Syntactically check is based on TS compiler function `ts.getPreEmitDiagnostics`. There are a list of error codes, that can be ignored or added.
| const syntaxErrors = checkSyntaxErrors(program, sourceFile); | ||
| if (syntaxErrors.length > 0) { | ||
| syntaxErrors.forEach( | ||
| e => result.push(ParseError.build(this, input, relativeTo, ctx, new SyntaxError(`Compiler error: ${e[0]} [${e[1]}]`), null)) |
There was a problem hiding this comment.
Could this end up creating multiple ParseErrors for one source file?
There was a problem hiding this comment.
Yes, there can be many ParseErrors for one source file
| // Other critical errors | ||
| ]); | ||
|
|
||
| const excludedCodes = new Set([1039, 1064, 1101, 1107, 1111, 1155, 1166, 1170, 1183, 1203, 1207, 1215, 1238, 1239, 1240, 1241, 1244, 1250, |
There was a problem hiding this comment.
Are there constants with readable names for all these codes?
There was a problem hiding this comment.
I can put here the code description.
The full list is available here https://github.com/microsoft/TypeScript/blob/main/src/compiler/diagnosticMessages.json
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a source file has syntax errors, the
ParseErroris generated, and the file is skipped from parsing.Syntactically, the check is based on the TS compiler function
ts.getPreEmitDiagnostics.There is a list of error codes that can be ignored or added.